Replace kind variable from validator API with Boolean stubout parameter.

src/trusted/validator/validation_cache_test.cc

 /*
  * Copyright (c) 2012 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "gtest/gtest.h"
 
 #include "native_client/src/include/nacl_compiler_annotations.h"
 #include "native_client/src/shared/platform/nacl_log.h"
@@ skipping 116 matching lines @@
     bundle_size = 32;
 
     memset(code_buffer, 0x90, sizeof(code_buffer));
   }
 
   NaClValidationStatus Validate() {
     return NACL_SUBARCH_NAME(ApplyValidator,
                              NACL_TARGET_ARCH,
                              NACL_TARGET_SUBARCH)(
                                  NACL_SB_DEFAULT,
-                                 NaClApplyCodeValidation,
                                  0, code_buffer, 32,
-                                 bundle_size, FALSE, &cpu_features,
+                                 bundle_size, FALSE, FALSE, &cpu_features,

[Mark Seaborn, 2012/04/10 00:57:38]

Could you add comments for the args here too, perhaps?

[Nick Bray (chromium), 2012/04/10 18:49:20]

Done.

                                  &cache);
   }
 };
 
 TEST_F(ValidationCachingInterfaceTests, Sanity) {
   void *query = cache.CreateQuery(cache.handle);
   cache.AddData(query, NULL, 6);
   cache.AddData(query, NULL, 128);
   EXPECT_EQ(1, cache.QueryKnownToValidate(query));
   cache.DestroyQuery(query);
   EXPECT_EQ(true, context.query_destroyed);
 }
 
 TEST_F(ValidationCachingInterfaceTests, NoCache) {
   NaClValidationStatus status =
       NACL_SUBARCH_NAME(ApplyValidator,
                         NACL_TARGET_ARCH,
                         NACL_TARGET_SUBARCH)(
                             NACL_SB_DEFAULT,
-                            NaClApplyCodeValidation,
                             0, code_buffer, CODE_SIZE,
-                            bundle_size, FALSE, &cpu_features,
+                            bundle_size, FALSE, FALSE, &cpu_features,
                             NULL);
   EXPECT_EQ(NaClValidationSucceeded, status);
 }
 
 TEST_F(ValidationCachingInterfaceTests, CacheHit) {
   NaClValidationStatus status = Validate();
   EXPECT_EQ(NaClValidationSucceeded, status);
   EXPECT_EQ(true, context.query_destroyed);
 }
 
@@ skipping 42 matching lines @@
 // Test driver function.
 int main(int argc, char *argv[]) {
   // The IllegalInst test touches the log mutex deep inside the validator.
   // This causes an SEH exception to be thrown on Windows if the mutex is not
   // initialized.
   // http://code.google.com/p/nativeclient/issues/detail?id=1696
   NaClLogModuleInit();
   testing::InitGoogleTest(&argc, argv);
   return RUN_ALL_TESTS();
 }