src/trusted/validator_x86/ncenuminsts_x86_32.c - Issue 10024039: Replace kind variable from validator API with Boolean stubout parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/validator_x86/ncenuminsts_x86_32.c

Issue 10024039: Replace kind variable from validator API with Boolean stubout parameter. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/trusted/validator/validation_cache_test.cc ('K') | « src/trusted/validator_arm/ncvalidate.cc ('k') | src/trusted/validator_x86/ncenuminsts_x86_64.c » ('j') | src/trusted/validator_x86/ncenuminsts_x86_64.c » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/trusted/validator_x86/ncenuminsts_x86_32.c

diff --git a/src/trusted/validator_x86/ncenuminsts_x86_32.c b/src/trusted/validator_x86/ncenuminsts_x86_32.c

index 259e6dc329d54e721ea1752b63ab34f51468f898..37d6dbc8fc4157c16f031d5345d8528f6e1157f6 100644

--- a/src/trusted/validator_x86/ncenuminsts_x86_32.c

+++ b/src/trusted/validator_x86/ncenuminsts_x86_32.c

@@ -104,8 +104,8 @@ Bool NaClSegmentValidates(uint8_t* mbase,

/* check if NaCl thinks the given code segment is valid. */

NaClSetAllCPUFeatures(&cpu_features);

status = NaCl_ApplyValidator_x86_32(

- NACL_SB_DEFAULT, NaClApplyCodeValidation, vbase, mbase, size, 32,

- FALSE, &cpu_features, NULL);

+ NACL_SB_DEFAULT, vbase, mbase, size, 32,

+ FALSE, FALSE, &cpu_features, NULL);

Mark Seaborn 2012/04/10 00:57:38 Again, labelling the args would be good for readab

Nick Bray (chromium) 2012/04/10 18:49:20 Done.

switch (status) {

case NaClValidationSucceeded:

return TRUE;