Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 10022011: Use Scoped COM helpers for collecting GPU information (Closed)

Created:
8 years, 8 months ago by Ryan Sleevi
Modified:
8 years, 8 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Use Scoped COM helpers for collecting GPU information Change explicit COM functions to use the scoped helpers from base::win, ensuring that releasing happens in the proper order. R=zmo,kbr BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131479

Patch Set 1 #

Patch Set 2 : One more #

Patch Set 3 : Update test - Release is now called outside this method #

Patch Set 4 : License bump #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -68 lines) Patch
M content/gpu/gpu_info_collector_unittest_win.cc View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M content/gpu/gpu_info_collector_win.cc View 1 5 chunks +51 lines, -66 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Ryan Sleevi
zmo: PTAL (and see e-mail). If this can result in a real bug, can you ...
8 years, 8 months ago (2012-04-07 06:08:27 UTC) #1
Zhenyao Mo
LGTM
8 years, 8 months ago (2012-04-09 17:38:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10022011/1
8 years, 8 months ago (2012-04-09 17:42:40 UTC) #3
commit-bot: I haz the power
Presubmit check for 10022011-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 8 months ago (2012-04-09 17:42:42 UTC) #4
Ryan Sleevi
kbr: TBR
8 years, 8 months ago (2012-04-09 17:55:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10022011/1
8 years, 8 months ago (2012-04-09 17:56:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10022011/6003
8 years, 8 months ago (2012-04-09 18:26:34 UTC) #7
commit-bot: I haz the power
Try job failure for 10022011-6003 (retry) on win_rel for step "content_unittests". It's a second try, ...
8 years, 8 months ago (2012-04-09 20:38:44 UTC) #8
Ken Russell (switch to Gerrit)
8 years, 8 months ago (2012-04-09 22:06:57 UTC) #9
OWNERS lgtm

Powered by Google App Engine
This is Rietveld 408576698