Issue 10020046: Merge 131370 - Don't recreate background windows when allow_js_access if false

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10020046: Merge 131370 - Don't recreate background windows when allow_js_access if false (Closed)

Created:
8 years, 8 months ago by Andrew T Wilson (Slow)

Modified:
8 years, 8 months ago

Reviewers:
Mihai Parparita -not on Chrome

CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1084/src/

Visibility:
Public.

Merge 131370 - Don't recreate background windows when allow_js_access if false Ignore calls to window.open(..., "background") with allow_js_access: false when there's already a BackgroundContents instance. BUG=122408 R=creis@chromium.org Review URL: http://codereview.chromium.org/10012053 TBR=mihaip@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131820

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -6 lines)			Patch
M	chrome/browser/extensions/app_background_page_apitest.cc	View	3 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View	1 chunk	+8 lines, -3 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/app_background_page/no_js/bg.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/app_background_page/no_js/test.js	View	3 chunks	+32 lines, -3 lines	0 comments	Download

Total messages: 1 (0 generated)