Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 10014024: TabContents -> WebContentsImpl, part 2. (Closed)

Created:
8 years, 8 months ago by Avi (use Gerrit)
Modified:
8 years, 8 months ago
Reviewers:
jam
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, jam, dcheng, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

TabContents -> WebContentsImpl, part 2. BUG=105875 TEST=no change Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131599

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -2564 lines) Patch
M chrome/browser/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_view_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents_view_gtk.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/tab_contents/tab_contents_view_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/web_contents_drag_win.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/tab_contents/web_contents_view_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
D content/browser/tab_contents/web_drag_dest_gtk.h View 1 chunk +0 lines, -108 lines 0 comments Download
D content/browser/tab_contents/web_drag_dest_gtk.cc View 1 chunk +0 lines, -276 lines 0 comments Download
D content/browser/tab_contents/web_drag_dest_mac.h View 1 chunk +0 lines, -79 lines 0 comments Download
D content/browser/tab_contents/web_drag_dest_mac.mm View 1 chunk +0 lines, -251 lines 0 comments Download
D content/browser/tab_contents/web_drag_dest_mac_unittest.mm View 1 chunk +0 lines, -164 lines 0 comments Download
D content/browser/tab_contents/web_drag_dest_win.h View 1 chunk +0 lines, -81 lines 0 comments Download
D content/browser/tab_contents/web_drag_dest_win.cc View 1 chunk +0 lines, -209 lines 0 comments Download
D content/browser/tab_contents/web_drag_source_gtk.h View 1 chunk +0 lines, -115 lines 0 comments Download
D content/browser/tab_contents/web_drag_source_gtk.cc View 1 chunk +0 lines, -410 lines 0 comments Download
D content/browser/tab_contents/web_drag_source_mac.h View 1 chunk +0 lines, -87 lines 0 comments Download
D content/browser/tab_contents/web_drag_source_mac.mm View 1 chunk +0 lines, -453 lines 0 comments Download
D content/browser/tab_contents/web_drag_source_win.h View 1 chunk +0 lines, -69 lines 0 comments Download
D content/browser/tab_contents/web_drag_source_win.cc View 1 chunk +0 lines, -126 lines 0 comments Download
D content/browser/tab_contents/web_drag_utils_win.h View 1 chunk +0 lines, -23 lines 0 comments Download
D content/browser/tab_contents/web_drag_utils_win.cc View 1 chunk +0 lines, -61 lines 0 comments Download
A + content/browser/web_contents/web_drag_dest_gtk.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/web_contents/web_drag_dest_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/web_contents/web_drag_dest_mac.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/web_contents/web_drag_dest_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/web_contents/web_drag_dest_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/web_contents/web_drag_dest_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/web_contents/web_drag_dest_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/web_contents/web_drag_source_gtk.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/web_contents/web_drag_source_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/web_contents/web_drag_source_mac.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/web_contents/web_drag_source_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/web_contents/web_drag_source_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/web_contents/web_drag_source_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/web_contents/web_drag_utils_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/web_contents/web_drag_utils_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 2 chunks +18 lines, -18 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
8 years, 8 months ago (2012-04-10 18:05:39 UTC) #1
jam
lgtm
8 years, 8 months ago (2012-04-10 18:48:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10014024/1
8 years, 8 months ago (2012-04-10 18:50:12 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-10 18:50:30 UTC) #4
Presubmit check for 10014024-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
New code should not use wstrings.  If you are calling an API that accepts a
wstring, fix the API.
    content/browser/web_contents/web_drag_dest_win.cc:73
    content/browser/web_contents/web_drag_dest_win.cc:74

New code should not use ScopedAllowIO. Post a task to the blocking pool or the
FILE thread instead.
    content/browser/web_contents/web_drag_source_gtk.cc:123

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui

Presubmit checks took 2.2s to calculate.

Powered by Google App Engine
This is Rietveld 408576698