Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10012004: Implemented proper support for checking schemes and requested resource types. (Closed)

Created:
8 years, 8 months ago by battre
Modified:
8 years, 8 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org
Visibility:
Public.

Description

Implemented proper support for checking schemes and requested resource types. This CL implements filter support for schemes that is handled by the URLMatcher, where it should be. In order to not lose the last WebRequestConditionAttribute implementation, support for filtering by ResourceType has been implemented in this CL as well. BUG=112155 TEST=no Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132003

Patch Set 1 #

Total comments: 7

Patch Set 2 : Addressed comments #

Patch Set 3 : Add algorithm stl header for MSVC #

Patch Set 4 : Renamed 'scheme' to 'schemes' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+439 lines, -133 lines) Patch
M chrome/browser/extensions/api/declarative/url_matcher.h View 3 chunks +23 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/declarative/url_matcher.cc View 3 chunks +30 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/declarative/url_matcher_unittest.cc View 2 chunks +28 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc View 1 2 3 6 chunks +27 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute.h View 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute.cc View 1 2 5 chunks +48 lines, -25 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc View 2 chunks +33 lines, -10 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_unittest.cc View 1 2 3 5 chunks +18 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_constants.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_constants.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
A chrome/browser/extensions/api/declarative_webrequest/webrequest_helpers.h View 1 chunk +28 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/declarative_webrequest/webrequest_helpers.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc View 1 2 3 8 chunks +15 lines, -11 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.cc View 5 chunks +6 lines, -59 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_helpers.h View 2 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_helpers.cc View 2 chunks +64 lines, -0 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/experimental.webRequest.json View 1 2 3 1 chunk +11 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/experimental.webRequest.html View 1 2 3 2 chunks +39 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/webrequest/test_declarative.js View 1 2 3 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
battre
Hi Matt, please review. Thank you. Best regards, Dominic https://chromiumcodereview.appspot.com/10012004/diff/1/chrome/browser/extensions/api/web_request/web_request_api.cc File chrome/browser/extensions/api/web_request/web_request_api.cc (left): https://chromiumcodereview.appspot.com/10012004/diff/1/chrome/browser/extensions/api/web_request/web_request_api.cc#oldcode73 chrome/browser/extensions/api/web_request/web_request_api.cc:73: ...
8 years, 8 months ago (2012-04-05 15:01:10 UTC) #1
Matt Perry
lgtm https://chromiumcodereview.appspot.com/10012004/diff/1/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc File chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc (right): https://chromiumcodereview.appspot.com/10012004/diff/1/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc#newcode270 chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc:270: new URLMatcherSchemeFilter(schemas)); can also use make_scoped_ptr() https://chromiumcodereview.appspot.com/10012004/diff/1/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.h File ...
8 years, 8 months ago (2012-04-05 19:07:13 UTC) #2
battre
https://chromiumcodereview.appspot.com/10012004/diff/1/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc File chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc (right): https://chromiumcodereview.appspot.com/10012004/diff/1/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc#newcode270 chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc:270: new URLMatcherSchemeFilter(schemas)); On 2012/04/05 19:07:13, Matt Perry wrote: > ...
8 years, 8 months ago (2012-04-11 22:08:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/10012004/6001
8 years, 8 months ago (2012-04-11 22:10:04 UTC) #4
Matt Perry
https://chromiumcodereview.appspot.com/10012004/diff/1/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc File chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc (right): https://chromiumcodereview.appspot.com/10012004/diff/1/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc#newcode270 chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc:270: new URLMatcherSchemeFilter(schemas)); On 2012/04/11 22:08:23, battre wrote: > On ...
8 years, 8 months ago (2012-04-11 22:25:27 UTC) #5
commit-bot: I haz the power
Try job failure for 10012004-6001 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-11 23:00:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/10012004/16001
8 years, 8 months ago (2012-04-12 01:45:21 UTC) #7
commit-bot: I haz the power
Try job failure for 10012004-16001 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 8 months ago (2012-04-12 05:13:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/10012004/16001
8 years, 8 months ago (2012-04-12 06:10:20 UTC) #9
commit-bot: I haz the power
8 years, 8 months ago (2012-04-12 09:10:19 UTC) #10 
Try job failure for 10012004-16001 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698