Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3978)

Unified Diff: chrome/browser/resources/feedback.js

Issue 10010019: JS style nits (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: couple more Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/crashes.js ('k') | chrome/browser/resources/flags.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/feedback.js
diff --git a/chrome/browser/resources/feedback.js b/chrome/browser/resources/feedback.js
index fc0588fcb38e90120d8eccea99870dccc58a7a3c..c5293401db7f81b71fdcde4621d6b3181356c9d8 100644
--- a/chrome/browser/resources/feedback.js
+++ b/chrome/browser/resources/feedback.js
@@ -3,8 +3,8 @@
// found in the LICENSE file.
// Constants.
-var FEEDBACK_LANDING_PAGE =
- 'http://www.google.com/support/chrome/go/feedback_confirmation'
+/** @const */ var FEEDBACK_LANDING_PAGE =
+ 'http://www.google.com/support/chrome/go/feedback_confirmation';
var selectedThumbnailDivId = '';
var selectedThumbnailId = '';
@@ -14,7 +14,7 @@ var savedThumbnailIds = [];
savedThumbnailIds['current-screenshots'] = '';
savedThumbnailIds['saved-screenshots'] = '';
-var categoryTag = "";
+var categoryTag = '';
var localStrings = new LocalStrings();
@@ -110,7 +110,7 @@ function sendReport() {
// Add chromeos data if it exists.
if ($('user-email-text') && $('sys-info-checkbox')) {
- var userEmail= $('user-email-text').textContent;
+ var userEmail = $('user-email-text').textContent;
if (!$('user-email-checkbox').checked)
userEmail = '';
reportArray = reportArray.concat([userEmail,
@@ -124,7 +124,7 @@ function sendReport() {
}
function cancel() {
- chrome.send('cancel', []);
+ chrome.send('cancel');
return true;
}
@@ -154,7 +154,7 @@ function savedSelected() {
if ($('saved-screenshots').childElementCount == 0) {
// setupSavedScreenshots will take care of changing visibility
- chrome.send('refreshSavedScreenshots', []);
+ chrome.send('refreshSavedScreenshots');
} else {
$('saved-screenshots').hidden = false;
if (selectedThumbnailDivId != 'saved-screenshots')
@@ -251,9 +251,9 @@ function load() {
// Pick up the category tag (for most cases this will be an empty string)
categoryTag = parameters['categoryTag'];
- chrome.send('getDialogDefaults', []);
- chrome.send('refreshCurrentScreenshot', []);
-};
+ chrome.send('getDialogDefaults');
+ chrome.send('refreshCurrentScreenshot');
+}
function setupCurrentScreenshot(screenshot) {
addScreenshot('current-screenshots', screenshot);
« no previous file with comments | « chrome/browser/resources/crashes.js ('k') | chrome/browser/resources/flags.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698