Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: chrome/browser/resources/flags.js

Issue 10010019: JS style nits (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: couple more Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/feedback.js ('k') | chrome/browser/resources/plugins.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/flags.js
diff --git a/chrome/browser/resources/flags.js b/chrome/browser/resources/flags.js
index 116810c481d119121e0ae98d5b48d104f2ae1a8f..640e0680df882190718b8a444b1724dcb4bec7b3 100644
--- a/chrome/browser/resources/flags.js
+++ b/chrome/browser/resources/flags.js
@@ -47,7 +47,7 @@ function renderTemplate(flagsExperimentsData) {
// Add handlers to dynamically created HTML elements.
var elements = document.getElementsByClassName('experiment-select');
for (var i = 0; i < elements.length; ++i) {
- elements[i].onchange = function () {
+ elements[i].onchange = function() {
handleSelectChoiceExperiment(this, this.selectedIndex);
return false;
};
@@ -55,7 +55,7 @@ function renderTemplate(flagsExperimentsData) {
elements = document.getElementsByClassName('experiment-disable-link');
for (var i = 0; i < elements.length; ++i) {
- elements[i].onclick = function () {
+ elements[i].onclick = function() {
handleEnableExperiment(this, false);
return false;
};
@@ -63,7 +63,7 @@ function renderTemplate(flagsExperimentsData) {
elements = document.getElementsByClassName('experiment-enable-link');
for (var i = 0; i < elements.length; ++i) {
- elements[i].onclick = function () {
+ elements[i].onclick = function() {
handleEnableExperiment(this, true);
return false;
};
@@ -81,21 +81,21 @@ function renderTemplate(flagsExperimentsData) {
* should reply to returnFlagsExperiments() (below).
*/
function requestFlagsExperimentsData() {
- chrome.send('requestFlagsExperiments', []);
+ chrome.send('requestFlagsExperiments');
}
/**
* Asks the C++ FlagsDOMHandler to restart the browser (restoring tabs).
*/
function restartBrowser() {
- chrome.send('restartBrowser', []);
+ chrome.send('restartBrowser');
}
/**
* Called by the WebUI to re-populate the page with data representing the
* current state of installed experiments.
*/
-function returnFlagsExperiments(flagsExperimentsData){
+function returnFlagsExperiments(flagsExperimentsData) {
var bodyContainer = document.getElementById('body-container');
renderTemplate(flagsExperimentsData);
bodyContainer.style.visibility = 'visible';
@@ -107,7 +107,7 @@ function returnFlagsExperiments(flagsExperimentsData){
function handleEnableExperiment(node, enable) {
// Tell the C++ FlagsDOMHandler to enable/disable the experiment.
chrome.send('enableFlagsExperiment', [String(node.internal_name),
- String(enable)]);
+ String(enable)]);
requestFlagsExperimentsData();
}
@@ -118,7 +118,7 @@ function handleEnableExperiment(node, enable) {
function handleSelectChoiceExperiment(node, index) {
// Tell the C++ FlagsDOMHandler to enable the selected choice.
chrome.send('enableFlagsExperiment',
- [String(node.internal_name) + "@" + index, "true"]);
+ [String(node.internal_name) + '@' + index, 'true']);
requestFlagsExperimentsData();
}
« no previous file with comments | « chrome/browser/resources/feedback.js ('k') | chrome/browser/resources/plugins.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698