JS style nits

chrome/browser/resources/flags.js

Index: chrome/browser/resources/flags.js
diff --git a/chrome/browser/resources/flags.js b/chrome/browser/resources/flags.js
index 116810c481d119121e0ae98d5b48d104f2ae1a8f..a9f212dab74640d18b4989d19c753e3783faed78 100644
--- a/chrome/browser/resources/flags.js
+++ b/chrome/browser/resources/flags.js
@@ -47,7 +47,7 @@ function renderTemplate(flagsExperimentsData) {
   // Add handlers to dynamically created HTML elements.
   var elements = document.getElementsByClassName('experiment-select');
   for (var i = 0; i < elements.length; ++i) {
-    elements[i].onchange = function () {
+    elements[i].onchange = function() {

[Dan Beam, 2012/04/05 22:24:13]

STEPHEN! (jk, saw this when I reviewed his patch, didn't matter at the time
[started looking around, urge to kill rose])

       handleSelectChoiceExperiment(this, this.selectedIndex);
       return false;
     };
@@ -55,7 +55,7 @@ function renderTemplate(flagsExperimentsData) {
 
   elements = document.getElementsByClassName('experiment-disable-link');
   for (var i = 0; i < elements.length; ++i) {
-    elements[i].onclick = function () {
+    elements[i].onclick = function() {
       handleEnableExperiment(this, false);
       return false;
     };
@@ -63,7 +63,7 @@ function renderTemplate(flagsExperimentsData) {
 
   elements = document.getElementsByClassName('experiment-enable-link');
   for (var i = 0; i < elements.length; ++i) {
-    elements[i].onclick = function () {
+    elements[i].onclick = function() {
       handleEnableExperiment(this, true);
       return false;
     };
@@ -81,21 +81,21 @@ function renderTemplate(flagsExperimentsData) {
  * should reply to returnFlagsExperiments() (below).
  */
 function requestFlagsExperimentsData() {
-  chrome.send('requestFlagsExperiments', []);
+  chrome.send('requestFlagsExperiments');
 }
 
 /**
  * Asks the C++ FlagsDOMHandler to restart the browser (restoring tabs).
  */
 function restartBrowser() {
-  chrome.send('restartBrowser', []);
+  chrome.send('restartBrowser');
 }
 
 /**
  * Called by the WebUI to re-populate the page with data representing the
  * current state of installed experiments.
  */
-function returnFlagsExperiments(flagsExperimentsData){
+function returnFlagsExperiments(flagsExperimentsData) {
   var bodyContainer = document.getElementById('body-container');
   renderTemplate(flagsExperimentsData);
   bodyContainer.style.visibility = 'visible';
@@ -118,7 +118,7 @@ function handleEnableExperiment(node, enable) {
 function handleSelectChoiceExperiment(node, index) {
   // Tell the C++ FlagsDOMHandler to enable the selected choice.
   chrome.send('enableFlagsExperiment',
-              [String(node.internal_name) + "@" + index, "true"]);
+              [String(node.internal_name) + '@' + index, 'true']);

[Dan Beam, 2012/04/05 22:24:13]

'true' vs. true?!

[Tyler Breisacher (Chromium), 2012/04/05 22:49:55]

The C++ is probably set up to only take strings. I don't want to mess with that
right now, but yes, any time I see a string literal "null" or "true" or
whatever, I'm suspicious of it...

   requestFlagsExperimentsData();
 }