JS style nits

chrome/browser/resources/feedback.js

Index: chrome/browser/resources/feedback.js
diff --git a/chrome/browser/resources/feedback.js b/chrome/browser/resources/feedback.js
index fc0588fcb38e90120d8eccea99870dccc58a7a3c..d3df0dea07a2bd63eaee371c5ba7c4f5085b200a 100644
--- a/chrome/browser/resources/feedback.js
+++ b/chrome/browser/resources/feedback.js
@@ -4,7 +4,7 @@
 
 // Constants.
 var FEEDBACK_LANDING_PAGE =

[Dan Beam, 2012/04/05 22:24:13]

/** @const */

[Tyler Breisacher (Chromium), 2012/04/05 22:49:55]

Here, yes. The other constants are not actually constant -- it looks they're set
to '' here and then init'd to their real value later. So we should maybe
refactor in another CL...

[Dan Beam, 2012/04/06 02:58:29]

Only meant this one.

-    'http://www.google.com/support/chrome/go/feedback_confirmation'
+    'http://www.google.com/support/chrome/go/feedback_confirmation';
 
 var selectedThumbnailDivId = '';
 var selectedThumbnailId = '';
@@ -14,7 +14,7 @@ var savedThumbnailIds = [];
 savedThumbnailIds['current-screenshots'] = '';
 savedThumbnailIds['saved-screenshots'] = '';
 
-var categoryTag = "";
+var categoryTag = '';
 
 var localStrings = new LocalStrings();
 
@@ -110,7 +110,7 @@ function sendReport() {
 
   // Add chromeos data if it exists.
   if ($('user-email-text') && $('sys-info-checkbox')) {
-    var userEmail= $('user-email-text').textContent;
+    var userEmail = $('user-email-text').textContent;

[Dan Beam, 2012/04/05 22:24:13]

and this one, >:|

     if (!$('user-email-checkbox').checked)
       userEmail = '';
     reportArray = reportArray.concat([userEmail,
@@ -124,7 +124,7 @@ function sendReport() {
 }
 
 function cancel() {
-  chrome.send('cancel', []);
+  chrome.send('cancel');
   return true;
 }
 
@@ -154,7 +154,7 @@ function savedSelected() {
 
   if ($('saved-screenshots').childElementCount == 0) {
     // setupSavedScreenshots will take care of changing visibility
-    chrome.send('refreshSavedScreenshots', []);
+    chrome.send('refreshSavedScreenshots');
   } else {
     $('saved-screenshots').hidden = false;

[Dan Beam, 2012/04/05 22:24:13]

and this one, >:|

     if (selectedThumbnailDivId != 'saved-screenshots')
@@ -251,9 +251,9 @@ function load() {
   // Pick up the category tag (for most cases this will be an empty string)
   categoryTag = parameters['categoryTag'];
 
-  chrome.send('getDialogDefaults', []);
-  chrome.send('refreshCurrentScreenshot', []);
-};
+  chrome.send('getDialogDefaults');
+  chrome.send('refreshCurrentScreenshot');
+}
 
 function setupCurrentScreenshot(screenshot) {
   addScreenshot('current-screenshots', screenshot);