gdata: Support mouting archive file in GData cache

chrome/browser/chromeos/gdata/gdata_file_system.h

Index: chrome/browser/chromeos/gdata/gdata_file_system.h
diff --git a/chrome/browser/chromeos/gdata/gdata_file_system.h b/chrome/browser/chromeos/gdata/gdata_file_system.h
index 86fa02f082af1870719911bde1811c108e51db4f..af46003320a0b8101dc76e802acf84f5f39be24b 100644
--- a/chrome/browser/chromeos/gdata/gdata_file_system.h
+++ b/chrome/browser/chromeos/gdata/gdata_file_system.h
@@ -71,6 +71,13 @@ typedef base::Callback<void(base::PlatformFileError error,
                             GDataFileType file_type)>
     GetFileCallback;
 
+// Callback for SetMountedState.
+typedef base::Callback<void(base::PlatformFileError error,
+                            const FilePath& file_path,
+                            const std::string& file_name,
+                            const std::string& mount_type)>
+    SetMountedStateCallback;
+
 // Used for file operations like removing files.
 typedef base::Callback<void(base::PlatformFileError error,
                             base::ListValue* feed_list)>
@@ -183,6 +190,7 @@ class GDataFileSystemInterface {
   enum CachedFileOrigin {
     CACHED_FILE_FROM_SERVER = 0,
     CACHED_FILE_LOCALLY_MODIFIED,
+    CACHED_FILE_MOUNTED_ARCHIVE,

[Ben Chan, 2012/04/17 20:57:53]

nit: prefer CACHED_FILE_IN_USE or CACHED_FILE_MOUNTED as we may reuse this
mechanism for marking a cache file being opened as read-only.

[tbarzic, 2012/04/17 21:33:13]

We should probably add CACHED_FILE_MOUNTED_ARCHIVE to the cache_paths in
InsertGDataCachePaths in gdata_util.cc

Otherwise registered file browser handlers won't be able to read mounted
archives.

[hshi, 2012/04/17 22:10:39]

I am not sure that this applies to the case of mounted archives. It is similar
to the handling of locally modified ("dirty") files -- that the file itself is
placed under the PERSISTENT directory, but the filename is set to
<resource_id>.local (and <resource_id>.mounted for our case).

P.S. I am unable to locate the InsertGDataCachePaths function, maybe it is
renamed/moved?

   };
 
   // Enum defining type of file operation e.g. copy or move, etc.
@@ -356,6 +364,10 @@ class GDataFileSystemInterface {
   virtual bool GetFileInfoFromPath(const FilePath& gdata_file_path,
                                    GDataFileProperties* properties) = 0;
 
+  // Returns true if the given path is under gdata cache directory, i.e.
+  // <user_profile_dir>/GCache/v1
+  virtual bool IsUnderGDataCacheDirectory(const FilePath& path) const = 0;
+
   // Returns the tmp sub-directory under gdata cache directory, i.e.
   // <user_profile_dir>/GCache/v1/tmp
   virtual FilePath GetGDataCacheTmpDirectory() const = 0;
@@ -391,6 +403,16 @@ class GDataFileSystemInterface {
   virtual void SetPinState(const FilePath& file_path, bool to_pin,
                            const FileOperationCallback& callback) = 0;
 
+  // Set mounted state of an archive

[Ben Chan, 2012/04/17 20:57:53]

Prefer a more elaborated comment, e.g.

Marks a file as locally mounted to prevent it from being modified or evicted
from cache.

[tbarzic, 2012/04/17 21:33:13]

Also, comments must end with .

+  virtual void SetMountedState(const FilePath& file_path,
+                               const std::string& file_name,

[Ben Chan, 2012/04/17 20:57:53]

const FilePath::StringType&

+                               const std::string& mount_type,
+                               const SetMountedStateCallback& callback) = 0;
+
+  // Clear mounted state of an archive

[Ben Chan, 2012/04/17 20:57:53]

ditto

+  virtual void ClearMountedState(const FilePath& file_path,
+                                 const FileOperationCallback& callback) = 0;
+
   // Creates a new file from |entry| under |virtual_dir_path|. Stored its
   // content from |file_content_path| into the cache.
   virtual void AddUploadedFile(const FilePath& virtual_dir_path,
@@ -457,6 +479,7 @@ class GDataFileSystem : public GDataFileSystemInterface,
                              const GetCacheStateCallback& callback) OVERRIDE;
   virtual bool GetFileInfoFromPath(const FilePath& gdata_file_path,
                                    GDataFileProperties* properties) OVERRIDE;
+  virtual bool IsUnderGDataCacheDirectory(const FilePath& path) const OVERRIDE;
   virtual FilePath GetGDataCacheTmpDirectory() const OVERRIDE;
   virtual FilePath GetGDataTempDownloadFolderPath() const OVERRIDE;
   virtual FilePath GetGDataTempDocumentFolderPath() const OVERRIDE;
@@ -472,6 +495,12 @@ class GDataFileSystem : public GDataFileSystemInterface,
   // Calls private Pin or Unpin methods with |callback|.
   virtual void SetPinState(const FilePath& file_path, bool pin,
                            const FileOperationCallback& callback) OVERRIDE;
+  virtual void SetMountedState(const FilePath& file_path,
+                             const std::string& file_name,

[tbarzic, 2012/04/17 21:33:13]

fix indent

+                             const std::string& mount_type,
+                             const SetMountedStateCallback& callback) OVERRIDE;
+  virtual void ClearMountedState(const FilePath& file_path,
+                               const FileOperationCallback& callback) OVERRIDE;
   virtual void AddUploadedFile(const FilePath& virtual_dir_path,
                                DocumentEntry* entry,
                                const FilePath& file_content_path,