gdata: Support mouting archive file in GData cache

chrome/browser/chromeos/gdata/gdata_file_system.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_GDATA_GDATA_FILE_SYSTEM_H_
 #define CHROME_BROWSER_CHROMEOS_GDATA_GDATA_FILE_SYSTEM_H_
 #pragma once
 
 #include <sys/stat.h>
 
@@ skipping 53 matching lines @@
                             GDataFileBase* file)>
     FindFileCallback;
 
 // Used to get files from the file system.
 typedef base::Callback<void(base::PlatformFileError error,
                             const FilePath& file_path,
                             const std::string& mime_type,
                             GDataFileType file_type)>
     GetFileCallback;
 
+// Callback for SetMountedState.
+typedef base::Callback<void(base::PlatformFileError error,
+                            const FilePath& file_path,
+                            const std::string& file_name,
+                            const std::string& mount_type)>
+    SetMountedStateCallback;
+
 // Used for file operations like removing files.
 typedef base::Callback<void(base::PlatformFileError error,
                             base::ListValue* feed_list)>
     GetJsonDocumentCallback;
 
 // Used to get available space for the account from GData.
 typedef base::Callback<void(base::PlatformFileError error,
                             int bytes_total,
                             int bytes_used)>
     GetAvailableSpaceCallback;
@@ skipping 92 matching lines @@
   virtual void Initialize() = 0;
 
   // Adds and removes the observer.
   virtual void AddObserver(Observer* observer) = 0;
   virtual void RemoveObserver(Observer* observer) = 0;
 
   // Enum defining origin of a cached file.
   enum CachedFileOrigin {
     CACHED_FILE_FROM_SERVER = 0,
     CACHED_FILE_LOCALLY_MODIFIED,
+    CACHED_FILE_MOUNTED_ARCHIVE,

[Ben Chan, 2012/04/17 20:57:53]

nit: prefer CACHED_FILE_IN_USE or CACHED_FILE_MOUNTED as we may reuse this
mechanism for marking a cache file being opened as read-only.

[tbarzic, 2012/04/17 21:33:13]

We should probably add CACHED_FILE_MOUNTED_ARCHIVE to the cache_paths in
InsertGDataCachePaths in gdata_util.cc

Otherwise registered file browser handlers won't be able to read mounted
archives.

[hshi, 2012/04/17 22:10:39]

I am not sure that this applies to the case of mounted archives. It is similar
to the handling of locally modified ("dirty") files -- that the file itself is
placed under the PERSISTENT directory, but the filename is set to
<resource_id>.local (and <resource_id>.mounted for our case).

P.S. I am unable to locate the InsertGDataCachePaths function, maybe it is
renamed/moved?

   };
 
   // Enum defining type of file operation e.g. copy or move, etc.
   // For now, it's used for StoreToCache.
   enum FileOperationType {
     FILE_OPERATION_MOVE = 0,
     FILE_OPERATION_COPY,
   };
 
   // Authenticates the user by fetching the auth token as
@@ skipping 153 matching lines @@
   // otherwise.
   virtual void GetCacheState(const std::string& resource_id,
                              const std::string& md5,
                              const GetCacheStateCallback& callback) = 0;
 
   // Finds file object by |file_path| and returns its key |properties|.
   // Returns true if file was found.
   virtual bool GetFileInfoFromPath(const FilePath& gdata_file_path,
                                    GDataFileProperties* properties) = 0;
 
+  // Returns true if the given path is under gdata cache directory, i.e.
+  // <user_profile_dir>/GCache/v1
+  virtual bool IsUnderGDataCacheDirectory(const FilePath& path) const = 0;
+
   // Returns the tmp sub-directory under gdata cache directory, i.e.
   // <user_profile_dir>/GCache/v1/tmp
   virtual FilePath GetGDataCacheTmpDirectory() const = 0;
 
   // Returns the tmp downloads sub-directory under gdata cache directory, i.e.
   // <user_profile_dir>/GCache/v1/tmp/downloads/
   virtual FilePath GetGDataTempDownloadFolderPath() const = 0;
 
   // Returns the tmp documents sub-directory under gdata cache directory, i.e.
   // <user_profile_dir>/GCache/v1/tmp/documents/
@@ skipping 15 matching lines @@
       CachedFileOrigin file_orign) const = 0;
 
   // Fetches the user's Account Metadata to find out current quota information
   // and returns it to the callback.
   virtual void GetAvailableSpace(const GetAvailableSpaceCallback& callback) = 0;
 
   // Pin or unpin file.
   virtual void SetPinState(const FilePath& file_path, bool to_pin,
                            const FileOperationCallback& callback) = 0;
 
+  // Set mounted state of an archive

[Ben Chan, 2012/04/17 20:57:53]

Prefer a more elaborated comment, e.g.

Marks a file as locally mounted to prevent it from being modified or evicted
from cache.

[tbarzic, 2012/04/17 21:33:13]

Also, comments must end with .

+  virtual void SetMountedState(const FilePath& file_path,
+                               const std::string& file_name,

[Ben Chan, 2012/04/17 20:57:53]

const FilePath::StringType&

+                               const std::string& mount_type,
+                               const SetMountedStateCallback& callback) = 0;
+
+  // Clear mounted state of an archive

[Ben Chan, 2012/04/17 20:57:53]

ditto

+  virtual void ClearMountedState(const FilePath& file_path,
+                                 const FileOperationCallback& callback) = 0;
+
   // Creates a new file from |entry| under |virtual_dir_path|. Stored its
   // content from |file_content_path| into the cache.
   virtual void AddUploadedFile(const FilePath& virtual_dir_path,
                                DocumentEntry* entry,
                                const FilePath& file_content_path,
                                FileOperationType cache_operation) = 0;
 
   // Returns true if hosted documents should be hidden.
   virtual bool hide_hosted_documents() = 0;
 };
@@ skipping 46 matching lines @@
   virtual bool CancelOperation(const FilePath& file_path) OVERRIDE;
   virtual void AddOperationObserver(
       GDataOperationRegistry::Observer* observer) OVERRIDE;
   virtual void RemoveOperationObserver(
       GDataOperationRegistry::Observer* observer) OVERRIDE;
   virtual void GetCacheState(const std::string& resource_id,
                              const std::string& md5,
                              const GetCacheStateCallback& callback) OVERRIDE;
   virtual bool GetFileInfoFromPath(const FilePath& gdata_file_path,
                                    GDataFileProperties* properties) OVERRIDE;
+  virtual bool IsUnderGDataCacheDirectory(const FilePath& path) const OVERRIDE;
   virtual FilePath GetGDataCacheTmpDirectory() const OVERRIDE;
   virtual FilePath GetGDataTempDownloadFolderPath() const OVERRIDE;
   virtual FilePath GetGDataTempDocumentFolderPath() const OVERRIDE;
   virtual FilePath GetGDataCachePinnedDirectory() const OVERRIDE;
   virtual FilePath GetGDataCachePersistentDirectory() const OVERRIDE;
   virtual FilePath GetCacheFilePath(
       const std::string& resource_id,
       const std::string& md5,
       GDataRootDirectory::CacheSubDirectoryType sub_dir_type,
       CachedFileOrigin file_orign) const OVERRIDE;
   virtual void GetAvailableSpace(
       const GetAvailableSpaceCallback& callback) OVERRIDE;
   // Calls private Pin or Unpin methods with |callback|.
   virtual void SetPinState(const FilePath& file_path, bool pin,
                            const FileOperationCallback& callback) OVERRIDE;
+  virtual void SetMountedState(const FilePath& file_path,
+                             const std::string& file_name,

[tbarzic, 2012/04/17 21:33:13]

fix indent

+                             const std::string& mount_type,
+                             const SetMountedStateCallback& callback) OVERRIDE;
+  virtual void ClearMountedState(const FilePath& file_path,
+                               const FileOperationCallback& callback) OVERRIDE;
   virtual void AddUploadedFile(const FilePath& virtual_dir_path,
                                DocumentEntry* entry,
                                const FilePath& file_content_path,
                                FileOperationType cache_operation) OVERRIDE;
   virtual bool hide_hosted_documents() OVERRIDE;
 
   // content::NotificationObserver implementation.
   virtual void Observe(int type,
                        const content::NotificationSource& source,
                        const content::NotificationDetails& details) OVERRIDE;
@@ skipping 876 matching lines @@
 };
 
 // Sets the free disk space getter for testing.
 // The existing getter is deleted.
 void SetFreeDiskSpaceGetterForTesting(
     FreeDiskSpaceGetterInterface* getter);
 
 }  // namespace gdata
 
 #endif  // CHROME_BROWSER_CHROMEOS_GDATA_GDATA_FILE_SYSTEM_H_