content/browser/tab_contents/render_view_host_manager.cc - Issue 10008015: Fixing a problem, where a hung renderer process is not killed when navigating away

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/tab_contents/render_view_host_manager.cc

Issue 10008015: Fixing a problem, where a hung renderer process is not killed when navigating away (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixes based on feedback and new test Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_view_host_impl.cc ('K') | « content/browser/renderer_host/test_render_view_host.cc ('k') | content/browser/tab_contents/render_view_host_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/tab_contents/render_view_host_manager.cc

diff --git a/content/browser/tab_contents/render_view_host_manager.cc b/content/browser/tab_contents/render_view_host_manager.cc

index 687f2bf34830d0489370e7e36994ea22ceadf123..ce1203178fc2ba42534cf914ad027e083febceb9 100644

--- a/content/browser/tab_contents/render_view_host_manager.cc

+++ b/content/browser/tab_contents/render_view_host_manager.cc

@@ -187,10 +187,12 @@ bool RenderViewHostManager::ShouldCloseTabOnUnresponsiveRenderer() {

// handler later finishes, this call will be ignored because the state in

// CrossSiteResourceHandler will already be cleaned up.)

ViewMsg_SwapOut_Params params;

+ params.closing_process_id = render_view_host_->GetProcess()->GetID();

+ params.closing_route_id = render_view_host_->GetRoutingID();

params.new_render_process_host_id =

pending_render_view_host_->GetProcess()->GetID();

params.new_request_id = pending_request_id;

- current_host()->GetProcess()->CrossSiteSwapOutACK(params);

+ current_host()->GetProcess()->SimulateSwapOutACK(params);

}

return false;

}