content/browser/renderer_host/test_render_view_host.cc - Issue 10008015: Fixing a problem, where a hung renderer process is not killed when navigating away

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/test_render_view_host.cc

Issue 10008015: Fixing a problem, where a hung renderer process is not killed when navigating away (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixes based on feedback and new test Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_view_host_impl.cc ('K') | « content/browser/renderer_host/resource_dispatcher_host_impl.cc ('k') | content/browser/tab_contents/render_view_host_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/test_render_view_host.cc

diff --git a/content/browser/renderer_host/test_render_view_host.cc b/content/browser/renderer_host/test_render_view_host.cc

index 791fa17e4d232fb9cacf59edc222a48775fb3988..258a58f78035388cec7e3895a0179e4b81378ed5 100644

--- a/content/browser/renderer_host/test_render_view_host.cc

+++ b/content/browser/renderer_host/test_render_view_host.cc

@@ -274,7 +274,7 @@ void TestRenderViewHost::SetContentsMimeType(const std::string& mime_type) {

}

void TestRenderViewHost::SimulateSwapOutACK() {

- OnSwapOutACK();

+ OnSwapOutACK(false);

}

void TestRenderViewHost::SimulateWasHidden() {