Source/WebCore/bindings/v8/V8LazyEventListener.h - Issue 10007027: Merge 113086 - [v8] Fix memory leak in V8LazyEventListener

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/bindings/v8/V8LazyEventListener.h

Issue 10007027: Merge 113086 - [v8] Fix memory leak in V8LazyEventListener (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1084/

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/inline-event-attributes-release-expected.txt ('k') | Source/WebCore/bindings/v8/V8LazyEventListener.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebCore/bindings/v8/V8LazyEventListener.h

===================================================================

--- Source/WebCore/bindings/v8/V8LazyEventListener.h (revision 113392)

+++ Source/WebCore/bindings/v8/V8LazyEventListener.h (working copy)

@@ -48,7 +48,7 @@

// A V8LazyEventListener is either a HTML or SVG event handler.

class V8LazyEventListener : public V8AbstractEventListener {

public:

- static PassRefPtr<V8LazyEventListener> create(const AtomicString& functionName, const AtomicString& eventParameterName, const String& code, const String& sourceURL, const TextPosition& position, PassRefPtr<Node> node, const WorldContextHandle& worldContext)

+ static PassRefPtr<V8LazyEventListener> create(const AtomicString& functionName, const AtomicString& eventParameterName, const String& code, const String& sourceURL, const TextPosition& position, Node* node, const WorldContextHandle& worldContext)

{

return adoptRef(new V8LazyEventListener(functionName, eventParameterName, code, sourceURL, position, node, worldContext));

}

@@ -59,7 +59,7 @@

virtual void prepareListenerObject(ScriptExecutionContext*);

private:

- V8LazyEventListener(const AtomicString& functionName, const AtomicString& eventParameterName, const String& code, const String sourceURL, const TextPosition&, PassRefPtr<Node>, const WorldContextHandle&);

+ V8LazyEventListener(const AtomicString& functionName, const AtomicString& eventParameterName, const String& code, const String sourceURL, const TextPosition&, Node*, const WorldContextHandle&);

virtual v8::Local<v8::Value> callListenerFunction(ScriptExecutionContext*, v8::Handle<v8::Value> jsEvent, Event*);

@@ -73,8 +73,7 @@

AtomicString m_eventParameterName;

String m_code;

String m_sourceURL;

- RefPtr<Node> m_node;

- RefPtr<HTMLFormElement> m_formElement;

+ Node* m_node;

TextPosition m_position;

};