Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 10007027: Merge 113086 - [v8] Fix memory leak in V8LazyEventListener (Closed)

Created:
8 years, 8 months ago by arv (Not doing code reviews)
Modified:
8 years, 8 months ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1084/
Visibility:
Public.

Description

Merge 113086 - [v8] Fix memory leak in V8LazyEventListener https://bugs.webkit.org/show_bug.cgi?id=83057 Reviewed by Ojan Vafai. Source/WebCore: This also brings the V8 and JSC implementation closer. The timing when we first lookup the form element is now same in JSC and V8 (but different from Mozilla). This also clears the strings once the code has been parsed and the function created. Tests: fast/dom/inline-event-attributes-moved.html fast/dom/inline-event-attributes-release.html * bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::V8LazyEventListener): (WebCore::V8LazyEventListener::prepareListenerObject): * bindings/v8/V8LazyEventListener.h: (WebCore::V8LazyEventListener::create): (V8LazyEventListener): LayoutTests: * fast/dom/inline-event-attributes-moved-expected.txt: Added. * fast/dom/inline-event-attributes-moved.html: Added. * fast/dom/inline-event-attributes-release-expected.txt: Added. * fast/dom/inline-event-attributes-release.html: Added. TBR=arv@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=113393

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -9 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +12 lines, -0 lines 0 comments Download
A + LayoutTests/fast/dom/inline-event-attributes-moved.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/dom/inline-event-attributes-moved-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/dom/inline-event-attributes-release.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/dom/inline-event-attributes-release-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/bindings/v8/V8LazyEventListener.h View 3 chunks +3 lines, -4 lines 0 comments Download
M Source/WebCore/bindings/v8/V8LazyEventListener.cpp View 3 chunks +13 lines, -9 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
arv (Not doing code reviews)
8 years, 8 months ago (2012-04-05 23:26:28 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698