Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 10006048: Fixed some PP_X509Certificate_Private_Field enum values. (Closed)

Created:
8 years, 8 months ago by raymes
Modified:
8 years, 8 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

Fixed some PP_X509Certificate_Private_Field enum values. -Added PP_X509CERTIFICATE_PRIVATE_SUBJECT_DISTINGUISHED_NAME/PP_X509CERTIFICATE_PRIVATE_ISSUER_DISTINGUISHED_NAME which I had missed originally. -Renamed: PP_X509CERTIFICATE_PRIVATE_ALGORITHM_OID -> PP_X509CERTIFICATE_PRIVATE_SIGNATURE_ALGORITHM_OID PP_X509CERTIFICATE_PRIVATE_ALGORITHM_PARAMATERS_RAW -> PP_X509CERTIFICATE_PRIVATE_SIGNATURE_ALGORITHM_PARAMATERS_RAW To be in-line with the flash names. This also fixes a bug in the tcp socket shared implementation which allows a resource to be released in a callback, before it is finished cleaning up. BUG=114626 TEST=out/Debug/browser_tests --gtest_filter=*PPAPITest.*X509Certificate* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132013

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 1

Patch Set 4 : . #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -9 lines) Patch
M ppapi/api/private/ppb_x509_certificate_private.idl View 1 2 3 2 chunks +9 lines, -3 lines 0 comments Download
M ppapi/c/private/ppb_x509_certificate_private.h View 1 2 3 3 chunks +8 lines, -4 lines 0 comments Download
M ppapi/shared_impl/private/tcp_socket_private_impl.cc View 1 2 4 1 chunk +4 lines, -0 lines 0 comments Download
M ppapi/tests/test_x509_certificate_private.cc View 1 2 4 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
raymes
8 years, 8 months ago (2012-04-10 23:35:52 UTC) #1
yzshen1
https://chromiumcodereview.appspot.com/10006048/diff/8001/ppapi/api/private/ppb_x509_certificate_private.idl File ppapi/api/private/ppb_x509_certificate_private.idl (right): https://chromiumcodereview.appspot.com/10006048/diff/8001/ppapi/api/private/ppb_x509_certificate_private.idl#newcode41 ppapi/api/private/ppb_x509_certificate_private.idl:41: PP_X509CERTIFICATE_PRIVATE_ISSUER_DISTINGUISHED_NAME = 6, If M19 and M20 have different ...
8 years, 8 months ago (2012-04-11 07:26:52 UTC) #2
raymes
Hmm, yes. But the full support will only be in M20 anyway (i.e. flash secure ...
8 years, 8 months ago (2012-04-11 15:33:27 UTC) #3
raymes
Trung said not to modify the enums ever after it is comitted (because it could ...
8 years, 8 months ago (2012-04-12 00:22:47 UTC) #4
yzshen1
lgtm
8 years, 8 months ago (2012-04-12 00:25:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/10006048/11040
8 years, 8 months ago (2012-04-12 16:05:53 UTC) #6
commit-bot: I haz the power
8 years, 8 months ago (2012-04-12 17:56:42 UTC) #7
Change committed as 132013

Powered by Google App Engine
This is Rietveld 408576698