Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 10006036: Reverting again ... More crashes, and the instrumentation did not appear to help (Closed)

Created:
8 years, 8 months ago by Ryan Hamilton
Modified:
8 years, 8 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Reverting again ... More crashes, and the instrumentation did not appear to help Revert 130129 - Revert 129034 - Revert 127893 - Revert 127730 - Revert 127717 - Revert 118788 - Revert 113405 - Revert 113305 - Revert 113300 - Revert 112134 - Revert 112130 - Close idle connections / SPDY sessions when needed Due to the idle connection state being held by different socket pools, it's possible for one socket pool to hold an idle socket in a lower layer socket pool. From the lower level socket pool's perspective, the socket is being "actively" used. From the higher socket pool's (including SpdySession, which is more of a connection manager) perspective, the connection is idle and can be closed if we have hit a limit. Normally this isn't a big deal, except when we have a lot of idle SPDY connections and are connecting via a proxy, so we have low connection limits through the proxy server. We address this problem by allowing lower-level socket pools to tell higher level socket pools to close a socket. Fixed ASAN test failures by removing .Times(1) and .Times(2) from CloseMultipleIdleSocketsHeldByLayeredPoolWhenNeeded unittest (this removes the tests relying on the order of std::set in CloseOneIdleConnectionInLayeredPool). ASAN is prob ably causing the memory allocator to allocate the pools differently. The std::set is ordered by LayeredPool* which is the address of the LayeredPool (willchan). Added NET_EXPORT for layered_pool class defintion to fix windows shared compile. BUG=62364, 92244, 109876, 110368, 119847 TEST= Review URL: http://codereview.chromium.org/9861032 TBR=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131145

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1425 lines) Patch
M net/http/http_network_transaction_spdy21_unittest.cc View 1 chunk +0 lines, -181 lines 0 comments Download
M net/http/http_network_transaction_spdy2_unittest.cc View 1 chunk +0 lines, -181 lines 0 comments Download
M net/http/http_network_transaction_spdy3_unittest.cc View 1 chunk +0 lines, -181 lines 0 comments Download
M net/http/http_proxy_client_socket_pool.h View 4 chunks +1 line, -12 lines 0 comments Download
M net/http/http_proxy_client_socket_pool.cc View 4 chunks +2 lines, -34 lines 0 comments Download
M net/socket/client_socket_handle.h View 2 chunks +0 lines, -7 lines 0 comments Download
M net/socket/client_socket_handle.cc View 3 chunks +0 lines, -28 lines 0 comments Download
M net/socket/client_socket_pool.h View 4 chunks +0 lines, -37 lines 0 comments Download
M net/socket/client_socket_pool.cc View 2 chunks +1 line, -22 lines 0 comments Download
M net/socket/client_socket_pool_base.h View 11 chunks +12 lines, -41 lines 0 comments Download
M net/socket/client_socket_pool_base.cc View 9 chunks +15 lines, -87 lines 0 comments Download
M net/socket/client_socket_pool_base_unittest.cc View 16 chunks +4 lines, -219 lines 0 comments Download
M net/socket/socks_client_socket_pool.h View 4 chunks +1 line, -11 lines 0 comments Download
M net/socket/socks_client_socket_pool.cc View 4 chunks +1 line, -26 lines 0 comments Download
M net/socket/ssl_client_socket_pool.h View 4 chunks +0 lines, -10 lines 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 4 chunks +0 lines, -33 lines 0 comments Download
M net/socket/transport_client_socket_pool.h View 2 chunks +0 lines, -3 lines 0 comments Download
M net/socket/transport_client_socket_pool.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M net/spdy/spdy_session.h View 3 chunks +1 line, -7 lines 0 comments Download
M net/spdy/spdy_session.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M net/spdy/spdy_session_spdy2_unittest.cc View 1 chunk +0 lines, -140 lines 0 comments Download
M net/spdy/spdy_session_spdy3_unittest.cc View 1 chunk +0 lines, -140 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ryan Hamilton
8 years, 8 months ago (2012-04-06 17:26:29 UTC) #1
mmenke
8 years, 8 months ago (2012-04-06 17:39:16 UTC) #2
Suggestion:  Try it without hooking up SPDY.

Powered by Google App Engine
This is Rietveld 408576698