Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 10005037: Merge 112841 - Web Inspector: breakpoints are not shown in sidebar pane after switching pretty-prin… (Closed)

Created:
8 years, 8 months ago by pfeldman
Modified:
8 years, 8 months ago
Reviewers:
podivilov
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1084/
Visibility:
Public.

Description

Merge 112841 - Web Inspector: breakpoints are not shown in sidebar pane after switching pretty-print mode. https://bugs.webkit.org/show_bug.cgi?id=82768 Reviewed by Yury Semikhatsky. Source/WebCore: When UISourceCode is replaced with another in ScriptsPanel, newly added UISourceCode could already have breakpoints. We should iterate over existing breakpoints and add them to sidebar pane. * inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced): LayoutTests: * inspector/debugger/script-formatter-breakpoints-expected.txt: * inspector/debugger/script-formatter-breakpoints.html: TBR=podivilov@chromium.org BUG=122184 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=113432

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -3 lines) Patch
M LayoutTests/inspector/debugger/script-formatter-breakpoints.html View 3 chunks +18 lines, -1 line 0 comments Download
M LayoutTests/inspector/debugger/script-formatter-breakpoints-expected.txt View 1 chunk +18 lines, -0 lines 0 comments Download
M Source/WebCore/inspector/front-end/ScriptsPanel.js View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
pfeldman
8 years, 8 months ago (2012-04-06 14:23:59 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698