Issue 10005037: Merge 112841 - Web Inspector: breakpoints are not shown in sidebar pane after switching pretty-prin…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10005037: Merge 112841 - Web Inspector: breakpoints are not shown in sidebar pane after switching pretty-prin… (Closed)

Created:
8 years, 8 months ago by pfeldman

Modified:
8 years, 8 months ago

Reviewers:
podivilov

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1084/

Visibility:
Public.

More Reviews

Description

Merge 112841 - Web Inspector: breakpoints are not shown in sidebar pane after switching pretty-print mode. https://bugs.webkit.org/show_bug.cgi?id=82768 Reviewed by Yury Semikhatsky. Source/WebCore: When UISourceCode is replaced with another in ScriptsPanel, newly added UISourceCode could already have breakpoints. We should iterate over existing breakpoints and add them to sidebar pane. * inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced): LayoutTests: * inspector/debugger/script-formatter-breakpoints-expected.txt: * inspector/debugger/script-formatter-breakpoints.html: TBR=podivilov@chromium.org BUG=122184 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=113432

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -3 lines)			Patch
M	LayoutTests/inspector/debugger/script-formatter-breakpoints.html	View	3 chunks	+18 lines, -1 line	0 comments	Download
M	LayoutTests/inspector/debugger/script-formatter-breakpoints-expected.txt	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	Source/WebCore/inspector/front-end/ScriptsPanel.js	View	1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages