Implement object allocation/construction as effect (no result), sequence labels and unchaining fro…

runtime/vm/code_generator_ia32.cc

Index: runtime/vm/code_generator_ia32.cc
===================================================================
--- runtime/vm/code_generator_ia32.cc	(revision 6209)
+++ runtime/vm/code_generator_ia32.cc	(working copy)
@@ -964,7 +964,8 @@
     // The context saved on entry must be restored.
     if ((node_sequence == parsed_function_.node_sequence()) &&
         (parsed_function_.saved_context_var() != NULL)) {
-      GenerateLoadVariable(CTX, *parsed_function_.saved_context_var());
+      // Outermost sequence cannot have a label.
+      UNREACHABLE();

[regis, 2012/04/05 16:03:57]

Good point. A break out of the outermost sequence can only be a return
statement.
An assert instead of a condition + unreachable would not generate any code in
release mode, although efficiency is not an issue here.

[srdjan, 2012/04/05 16:23:11]

Done.

     }
   }
   set_context_level(previous_context_level);