Implement object allocation/construction as effect (no result), sequence labels and unchaining fro…

runtime/vm/code_generator_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/code_generator.h"
 
 #include "lib/error.h"
@@ skipping 946 matching lines @@
   }
 
   // If this node sequence is labeled, a break out of the sequence will have
   // taken care of unchaining the context.
   if (node_sequence->label() != NULL) {
     __ Bind(node_sequence->label()->break_label());
 
     // The context saved on entry must be restored.
     if ((node_sequence == parsed_function_.node_sequence()) &&
         (parsed_function_.saved_context_var() != NULL)) {
-      GenerateLoadVariable(CTX, *parsed_function_.saved_context_var());
+      // Outermost sequence cannot have a label.
+      UNREACHABLE();

[regis, 2012/04/05 16:03:57]

Good point. A break out of the outermost sequence can only be a return
statement.
An assert instead of a condition + unreachable would not generate any code in
release mode, although efficiency is not an issue here.

[srdjan, 2012/04/05 16:23:11]

Done.

     }
   }
   set_context_level(previous_context_level);
 }
 
 
 void CodeGenerator::VisitArgumentListNode(ArgumentListNode* arguments) {
   for (int i = 0; i < arguments->length(); i++) {
     AstNode* argument = arguments->NodeAt(i);
     argument->Visit(this);
@@ skipping 1863 matching lines @@
   const Error& error = Error::Handle(
       Parser::FormatError(script, token_index, "Error", format, args));
   va_end(args);
   Isolate::Current()->long_jump_base()->Jump(1, error);
   UNREACHABLE();
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32