Issue 10003005: Zero-sized windows are bad.

Issue 10003005: Zero-sized windows are bad. (Closed)

Created:
8 years, 8 months ago by Avi (use Gerrit)

Modified:
8 years, 8 months ago

Reviewers:
Robert Sesek

CC:
chromium-reviews, Aaron Boodman, James Su, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Zero-sized windows are bad. Eliminate three instances of them, and DCHECK on the condition for the future. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132280

Patch Set 1 #

Patch Set 2 : moar #

Patch Set 3 : rebase #

Patch Set 4 : constant #

Total comments: 2

Patch Set 5 : formatting #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -7 lines)			Patch
M	chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm	View	1 2 3	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm	View	1 2 3	2 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/cocoa/page_info_bubble_controller.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/status_bubble_mac.mm	View	1 2 3	2 chunks	+2 lines, -1 line	0 comments	Download
M	ui/base/cocoa/underlay_opengl_hosting_window.mm	View	1 2 3 4	1 chunk	+14 lines, -0 lines	0 comments	Download
A	ui/base/cocoa/window_size_constants.h	View	1 2 3	1 chunk	+20 lines, -0 lines	0 comments	Download
A	ui/base/cocoa/window_size_constants.mm	View	1 2 3	1 chunk	+11 lines, -0 lines	0 comments	Download
M	ui/ui.gyp	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

(0, 0, 1, 1) isn't really clear out of context. Let's define a constant kWindowSizeDeterminedAfterInitialization ...

8 years, 8 months ago (2012-04-13 18:18:51 UTC) #2

Avi (use Gerrit)

Suggestions on what header file to put that in? It's used also in the status ...

8 years, 8 months ago (2012-04-13 19:00:53 UTC) #3

Robert Sesek

On 2012/04/13 19:00:53, Avi wrote: > Suggestions on what header file to put that in? ...

8 years, 8 months ago (2012-04-13 19:15:54 UTC) #4

Robert Sesek

lgtm https://chromiumcodereview.appspot.com/10003005/diff/6002/ui/base/cocoa/underlay_opengl_hosting_window.mm File ui/base/cocoa/underlay_opengl_hosting_window.mm (right): https://chromiumcodereview.appspot.com/10003005/diff/6002/ui/base/cocoa/underlay_opengl_hosting_window.mm#newcode98 ui/base/cocoa/underlay_opengl_hosting_window.mm:98: // ui/base/cocoa/window_size_constants.h nit: no need to indent this ...

8 years, 8 months ago (2012-04-13 21:44:28 UTC) #6

Avi (use Gerrit)

8 years, 8 months ago (2012-04-17 14:21:16 UTC) #7

https://chromiumcodereview.appspot.com/10003005/diff/6002/ui/base/cocoa/under...
File ui/base/cocoa/underlay_opengl_hosting_window.mm (right):

https://chromiumcodereview.appspot.com/10003005/diff/6002/ui/base/cocoa/under...
ui/base/cocoa/underlay_opengl_hosting_window.mm:98: // 
ui/base/cocoa/window_size_constants.h
On 2012/04/13 21:44:28, rsesek wrote:
> nit: no need to indent this special. Can also join the next line.

Done.

Expand Messages | Collapse Messages