chrome/browser/ui/cocoa/status_bubble_mac.mm - Issue 10003005: Zero-sized windows are bad.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/status_bubble_mac.mm

Issue 10003005: Zero-sized windows are bad. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: formatting Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/status_bubble_mac.mm

diff --git a/chrome/browser/ui/cocoa/status_bubble_mac.mm b/chrome/browser/ui/cocoa/status_bubble_mac.mm

index 2806ae7969f0066979c7114d39305f3b9ff3daba..4f86f889ddf9825c512026e45cbb86f9eeeea845 100644

--- a/chrome/browser/ui/cocoa/status_bubble_mac.mm

+++ b/chrome/browser/ui/cocoa/status_bubble_mac.mm

@@ -18,6 +18,7 @@

#import "third_party/GTM/AppKit/GTMNSAnimation+Duration.h"

#import "third_party/GTM/AppKit/GTMNSBezierPath+RoundRect.h"

#import "third_party/GTM/AppKit/GTMNSColor+Luminance.h"

+#include "ui/base/cocoa/window_size_constants.h"

#include "ui/base/text/text_elider.h"

#include "ui/gfx/point.h"

@@ -359,7 +360,7 @@ void StatusBubbleMac::UpdateDownloadShelfVisibility(bool visible) {

void StatusBubbleMac::Create() {

DCHECK(!window_);

- window_ = [[NSWindow alloc] initWithContentRect:NSMakeRect(0, 0, 1, 1)

+ window_ = [[NSWindow alloc] initWithContentRect:ui::kWindowSizeDeterminedLater

styleMask:NSBorderlessWindowMask

backing:NSBackingStoreBuffered

defer:YES];