Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 10003002: Revert 132012 - net: move HSTS preloaded and pinning info out of code. (Closed)

Created:
8 years, 8 months ago by tim (not reviewing)
Modified:
8 years, 8 months ago
Reviewers:
agl
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Revert 132012 - net: move HSTS preloaded and pinning info out of code. This change moves information about HSTS preloaded and public key pinning, that were previously written in code, into external files that can be consumed by other programs. Those files are converted by a program (that is not part of the build process) into hsts_preloaded.h. In order to make this change easier to review, hsts_preloaded.h was created by concatenating public_key_hashes.h and transport_security_state.cc. Therefore, the diffs will show where the new, generated file differs from the previous code. public_key_hashes.h and public_key_hashes_check.go are removed and subsumed by hsts_preloaded.h. BUG=none TEST=net_unittests Review URL: https://chromiumcodereview.appspot.com/9863001 TBR=agl@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132016

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1748 lines, -1986 lines) Patch
A + net/base/public_key_hashes.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + net/base/public_key_hashes_check.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M net/base/transport_security_state.cc View 2 chunks +344 lines, -1 line 0 comments Download
M net/base/transport_security_state_static.h View 13 chunks +1406 lines, -65 lines 0 comments Download
D net/base/transport_security_state_static.certs View 1 chunk +0 lines, -1107 lines 0 comments Download
D net/base/transport_security_state_static.json View 1 chunk +0 lines, -267 lines 0 comments Download
D net/base/transport_security_state_static_generate.go View 1 chunk +0 lines, -547 lines 0 comments Download
M net/net.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
tim (not reviewing)
8 years, 8 months ago (2012-04-12 18:11:58 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698