net: move HSTS preloaded and pinning info out of code.

net: move HSTS preloaded and pinning info out of code.

This change moves information about HSTS preloaded and public key pinning, that
were previously written in code, into external files that can be consumed by
other programs. Those files are converted by a program (that is not part of the
build process) into hsts_preloaded.h.

In order to make this change easier to review, hsts_preloaded.h was created by
concatenating public_key_hashes.h and transport_security_state.cc. Therefore,
the diffs will show where the new, generated file differs from the previous
code.

public_key_hashes.h and public_key_hashes_check.go are removed and subsumed by
hsts_preloaded.h.

BUG=none
TEST=net_unittests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132012

[agl, 2012-03-26 21:20:29]

Mozilla asked for the HSTS preloaded list in a machine readable form.

However, this does remove the Twitter HSTS from ChromeOS. How much of a problem
is that? I was rather hoping, since we just did the M19 branch, we might get
Twitter HSTS for real before the next branch.

https://chromiumcodereview.appspot.com/9863001/diff/3009/net/base/hsts_preloa...
File net/base/hsts_preloaded.h (left):

https://chromiumcodereview.appspot.com/9863001/diff/3009/net/base/hsts_preloa...
net/base/hsts_preloaded.h:736:
MIIEKjCCAxKgAwIBAgIEOGPe+DANBgkqhkiG9w0BAQUFADCBtDEUMBIGA1UEChMLRW50cnVzdC5u
Note that this is the same certificate, but the PEM line length was corrected by
the tool.

[palmer, 2012-03-26 23:40:21]

https://chromiumcodereview.appspot.com/9863001/diff/3009/net/base/hsts_preloa...
File net/base/hsts_preloaded.h (right):

https://chromiumcodereview.appspot.com/9863001/diff/3009/net/base/hsts_preloa...
net/base/hsts_preloaded.h:14: -----BEGIN CERTIFICATE-----
Since the certificates are in the .certs file, maybe we don't need to output
them for this file? Not that it really matters except as an "avoid duplication"
thing.

https://chromiumcodereview.appspot.com/9863001/diff/3009/net/base/hsts_preloa...
File net/base/hsts_preloaded.json (right):

https://chromiumcodereview.appspot.com/9863001/diff/3009/net/base/hsts_preloa...
net/base/hsts_preloaded.json:131: { "name": "pinningtest.appspot.com",
"subdomains": true, "pins": "test" },
Can we use the same key names as I use in the TSS refactor? I document them in
chrome/browser/transport_security_persister.h in my TSS refactor CL
(http://codereview.chromium.org/9415040/). The more harmonized these names are,
the less confusing it will be for the poor maintainers that come after us.

One difference that I think would be ok is to have "static_spki_hashes" have a
string (the name of the array of pins from the JSON above this) instead of a
literal array of base64'd SPKI hashes, as they are in the persisted TSS data
file. I.e. I am just asking you to change these names; your new value semantics
are OK.

https://chromiumcodereview.appspot.com/9863001/diff/3009/net/base/hsts_preloa...
File net/base/hsts_preloaded_generate.go (right):

https://chromiumcodereview.appspot.com/9863001/diff/3009/net/base/hsts_preloa...
net/base/hsts_preloaded_generate.go:11: // % go run hsts_preloaded_generate.go
hsts_preloaded.json hsts_preloaded.certs
Same comment as before regarding these names: tss_static.* is more consistent.

https://chromiumcodereview.appspot.com/9863001/diff/3009/net/base/transport_s...
File net/base/transport_security_state.cc (right):

https://chromiumcodereview.appspot.com/9863001/diff/3009/net/base/transport_s...
net/base/transport_security_state.cc:1150: #include "net/base/hsts_preloaded.h"
Maybe call it tss_static.h? (It's not just HSTS per se since it involves
pinning; the static/dynamic is a more straightforward alternation than
preloaded/dynamic and we are now using static everywhere).

[agl, 2012-03-28 16:20:29]

Mass renaming done as requested.

https://chromiumcodereview.appspot.com/9863001/diff/3009/net/base/hsts_preloa...
File net/base/hsts_preloaded.h (right):

https://chromiumcodereview.appspot.com/9863001/diff/3009/net/base/hsts_preloa...
net/base/hsts_preloaded.h:14: -----BEGIN CERTIFICATE-----
On 2012/03/26 23:40:21, Chris P. wrote:
> Since the certificates are in the .certs file, maybe we don't need to output
> them for this file? Not that it really matters except as an "avoid
duplication"
> thing.

That's a fair point. Although I'd like to remove them in a future CL and aim to
keep the delta from this, complex CL as small as possible.

[palmer, 2012-04-10 19:49:14]

lgtm

[commit-bot: I haz the power, 2012-04-10 21:25:45]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[agl, 2012-04-11 14:51:02]

to cevans for rubber stamp LGTM.

[Chris Evans, 2012-04-11 15:04:29]

On 2012/04/11 14:51:02, agl wrote:
> to cevans for rubber stamp LGTM.

Duly LGTM

[commit-bot: I haz the power, 2012-04-11 15:15:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/agl@chromium.org/9863001/13001

[commit-bot: I haz the power, 2012-04-11 15:15:22]

Presubmit check for 9863001-13001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  net/base/transport_security_state_static.h, line 1, 86 chars \
  net/base/transport_security_state_static.h, line 1370, 83 chars \
  net/base/transport_security_state_static.h, line 1391, 91 chars \
  net/base/transport_security_state_static.h, line 1460, 81 chars \
  net/base/transport_security_state_static.h, line 1461, 87 chars

License must match:
.*? Copyright \(c\) 2012 The Chromium Authors\. All rights reserved\.\n.*? Use
of this source code is governed by a BSD-style license that can be\n.*? found in
the LICENSE file\.(?: \*/)?\n
Found a bad license header in these files:
  net/base/transport_security_state_static.h

Presubmit checks took 1.1s to calculate.