Issue 9969212: Reapplies (again) "Don't try to box immutable objects."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9969212: Reapplies (again) "Don't try to box immutable objects." (Closed)

Created:
8 years, 8 months ago by floitsch

Modified:
8 years, 8 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reapplies (again) "Don't try to box immutable objects." This reapplies commit 6631 plus a fix, so that captured fields in closures are mangled correctly. Original CL: https://chromiumcodereview.appspot.com//10091036 Committed: https://code.google.com/p/dart/source/detail?r=6679

Patch Set 1 #

Patch Set 2 : Undo fix. #

Patch Set 3 : Apply fix. #

Total comments: 2

Patch Set 4 : Address comment. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -19 lines)			Patch
M	lib/compiler/implementation/ssa/closure.dart	View	1 2 3	6 chunks	+34 lines, -18 lines	0 comments	Download
M	samples/tests/samples/samples-leg.status	View		1 chunk	+0 lines, -1 line	0 comments	Download
A	tests/language/src/Closure4Test.dart	View		1 chunk	+18 lines, -0 lines	0 comments	Download
A	tests/language/src/Closure5Test.dart	View		1 chunk	+18 lines, -0 lines	0 comments	Download
A	tests/language/src/Closure6Test.dart	View	2	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

Patchset 2 contains the original CL (without modifications). Patchset 3 contains the fix.

8 years, 8 months ago (2012-04-17 16:09:24 UTC) #1

ngeoffray

LGTM! https://chromiumcodereview.appspot.com/9969212/diff/2001/lib/compiler/implementation/ssa/closure.dart File lib/compiler/implementation/ssa/closure.dart (right): https://chromiumcodereview.appspot.com/9969212/diff/2001/lib/compiler/implementation/ssa/closure.dart#newcode34 lib/compiler/implementation/ssa/closure.dart:34: bool isInstanceMember() => false; I don't think you ...

8 years, 8 months ago (2012-04-18 08:12:54 UTC) #2

floitsch

8 years, 8 months ago (2012-04-18 10:57:39 UTC) #3

https://chromiumcodereview.appspot.com/9969212/diff/2001/lib/compiler/impleme...
File lib/compiler/implementation/ssa/closure.dart (right):

https://chromiumcodereview.appspot.com/9969212/diff/2001/lib/compiler/impleme...
lib/compiler/implementation/ssa/closure.dart:34: bool isInstanceMember() =>
false;
On 2012/04/18 08:12:54, ngeoffray wrote:
> I don't think you need this last method here, it's already the same in the
> Element class.

Done.

Expand Messages | Collapse Messages