Issue 10091036: Don't try to box immutable objects.

Issue 10091036: Don't try to box immutable objects. (Closed)

Created:
8 years, 8 months ago by floitsch

Modified:
8 years, 8 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't try to box immutable objects. Committed: https://code.google.com/p/dart/source/detail?r=6631

Patch Set 2 : rebase and update status file. #

Total comments: 4

Patch Set 3 : Addressed comments. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -7 lines)			Patch
M	lib/compiler/implementation/ssa/closure.dart	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	samples/tests/samples/samples-leg.status	View		1 chunk	+0 lines, -1 line	0 comments	Download
A	tests/language/src/Closure4Test.dart	View	1 2	1 chunk	+18 lines, -0 lines	0 comments	Download
A	tests/language/src/Closure5Test.dart	View	1 2	1 chunk	+18 lines, -0 lines	0 comments	Download
M	tests/utils/utils.status	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM! https://chromiumcodereview.appspot.com/10091036/diff/3001/tests/language/src/Closure4Test.dart File tests/language/src/Closure4Test.dart (right): https://chromiumcodereview.appspot.com/10091036/diff/3001/tests/language/src/Closure4Test.dart#newcode5 tests/language/src/Closure4Test.dart:5: // Having a declared function being captured within ...

8 years, 8 months ago (2012-04-17 13:06:12 UTC) #2

floitsch

8 years, 8 months ago (2012-04-17 13:09:00 UTC) #3

https://chromiumcodereview.appspot.com/10091036/diff/3001/tests/language/src/...
File tests/language/src/Closure4Test.dart (right):

https://chromiumcodereview.appspot.com/10091036/diff/3001/tests/language/src/...
tests/language/src/Closure4Test.dart:5: // Having a declared function being
captured within self tripped the dart2js
On 2012/04/17 13:06:12, ngeoffray wrote:
> self tripped -> used to self trip

that's not what I wanted to say. But reworded.

https://chromiumcodereview.appspot.com/10091036/diff/3001/tests/language/src/...
File tests/language/src/Closure5Test.dart (right):

https://chromiumcodereview.appspot.com/10091036/diff/3001/tests/language/src/...
tests/language/src/Closure5Test.dart:5: // Having a declared function being
captured within self tripped the dart2js
On 2012/04/17 13:06:12, ngeoffray wrote:
> ditto

ditto.

Expand Messages | Collapse Messages