Issue 9969062: Support 3-arg versions of .fromBuffer.

Issue 9969062: Support 3-arg versions of .fromBuffer. (Closed)

Created:
8 years, 8 months ago by Anton Muhin

Modified:
8 years, 8 months ago

Reviewers:
podivilov, sra, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support 3-arg versions of .fromBuffer. BUG=2362 TEST=TypedArrays2Test Committed: https://code.google.com/p/dart/source/detail?r=6104

Patch Set 1 #

Total comments: 4

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -9 lines)			Patch
	M	client/tests/client/client.status	View		1 chunk	+0 lines, -1 line	2 comments	Download
	M	lib/dom/src/native_FactoryProviders.dart	View		1 chunk	+16 lines, -8 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sra1

lgtm http://codereview.chromium.org/9969062/diff/1/client/tests/client/client.status File client/tests/client/client.status (right): http://codereview.chromium.org/9969062/diff/1/client/tests/client/client.status#newcode14 client/tests/client/client.status:14: html/TypedArrays2Test: Fail # Dartium dart:html needs to implement ...

8 years, 8 months ago (2012-04-02 19:25:26 UTC) #3

Anton Muhin

8 years, 8 months ago (2012-04-02 19:29:59 UTC) #4

http://codereview.chromium.org/9969062/diff/1/client/tests/client/client.status
File client/tests/client/client.status (right):

http://codereview.chromium.org/9969062/diff/1/client/tests/client/client.stat...
client/tests/client/client.status:14: html/TypedArrays2Test: Fail  # Dartium
dart:html needs to implement 3 arg constructor
On 2012/04/02 19:25:26, sra1 wrote:
> Does this one still not work?

That didn't work for me, but I might have missed something.

http://codereview.chromium.org/9969062/diff/1/lib/dom/src/native_FactoryProvi...
File lib/dom/src/native_FactoryProviders.dart (right):

http://codereview.chromium.org/9969062/diff/1/lib/dom/src/native_FactoryProvi...
lib/dom/src/native_FactoryProviders.dart:16: factory
Float32Array.fromBuffer(ArrayBuffer buffer, [int byteOffset, int length]) =>
On 2012/04/02 19:25:26, sra1 wrote:
> I think this fits in 80 col if you break at [

I'd rather leave as is, but if you insist, I'll fix it w/ a next change.

Expand Messages | Collapse Messages