Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Unified Diff: lib/dom/src/native_FactoryProviders.dart

Issue 9969062: Support 3-arg versions of .fromBuffer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« client/tests/client/client.status ('K') | « client/tests/client/client.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/dom/src/native_FactoryProviders.dart
diff --git a/lib/dom/src/native_FactoryProviders.dart b/lib/dom/src/native_FactoryProviders.dart
index 9a154c34e09dae3084a95f3e3802344c8a7116d7..c82302364e64e0ce49b4524f5619d67cf628f2bb 100644
--- a/lib/dom/src/native_FactoryProviders.dart
+++ b/lib/dom/src/native_FactoryProviders.dart
@@ -13,35 +13,43 @@ class _AudioContextFactoryProvider {
class _TypedArrayFactoryProvider {
factory Float32Array(int length) => FactoryProviderImplementation.F32(length);
factory Float32Array.fromList(List<num> list) => FactoryProviderImplementation.F32(list);
- factory Float32Array.fromBuffer(ArrayBuffer buffer) => FactoryProviderImplementation.F32(buffer);
+ factory Float32Array.fromBuffer(ArrayBuffer buffer, [int byteOffset, int length]) =>
sra1 2012/04/02 19:25:26 I think this fits in 80 col if you break at [
Anton Muhin 2012/04/02 19:29:59 I'd rather leave as is, but if you insist, I'll fi
+ FactoryProviderImplementation.F32(buffer, byteOffset, length);
factory Float64Array(int length) => FactoryProviderImplementation.F64(length);
factory Float64Array.fromList(List<num> list) => FactoryProviderImplementation.F64(list);
- factory Float64Array.fromBuffer(ArrayBuffer buffer) => FactoryProviderImplementation.F64(buffer);
+ factory Float64Array.fromBuffer(ArrayBuffer buffer, [int byteOffset, int length])
+ => FactoryProviderImplementation.F64(buffer, byteOffset, length);
factory Int8Array(int length) => FactoryProviderImplementation.I8(length);
factory Int8Array.fromList(List<num> list) => FactoryProviderImplementation.I8(list);
- factory Int8Array.fromBuffer(ArrayBuffer buffer) => FactoryProviderImplementation.I8(buffer);
+ factory Int8Array.fromBuffer(ArrayBuffer buffer, [int byteOffset, int length])
+ => FactoryProviderImplementation.I8(buffer, byteOffset, length);
factory Int16Array(int length) => FactoryProviderImplementation.I16(length);
factory Int16Array.fromList(List<num> list) => FactoryProviderImplementation.I16(list);
- factory Int16Array.fromBuffer(ArrayBuffer buffer) => FactoryProviderImplementation.I16(buffer);
+ factory Int16Array.fromBuffer(ArrayBuffer buffer, [int byteOffset, int length])
+ => FactoryProviderImplementation.I16(buffer, byteOffset, length);
factory Int32Array(int length) => FactoryProviderImplementation.I32(length);
factory Int32Array.fromList(List<num> list) => FactoryProviderImplementation.I32(list);
- factory Int32Array.fromBuffer(ArrayBuffer buffer) => FactoryProviderImplementation.I32(buffer);
+ factory Int32Array.fromBuffer(ArrayBuffer buffer, [int byteOffset, int length])
+ => FactoryProviderImplementation.I32(buffer, byteOffset, length);
factory Uint8Array(int length) => FactoryProviderImplementation.U8(length);
factory Uint8Array.fromList(List<num> list) => FactoryProviderImplementation.U8(list);
- factory Uint8Array.fromBuffer(ArrayBuffer buffer) => FactoryProviderImplementation.U8(buffer);
+ factory Uint8Array.fromBuffer(ArrayBuffer buffer, [int byteOffset, int length])
+ => FactoryProviderImplementation.U8(buffer, byteOffset, length);
factory Uint16Array(int length) => FactoryProviderImplementation.U16(length);
factory Uint16Array.fromList(List<num> list) => FactoryProviderImplementation.U16(list);
- factory Uint16Array.fromBuffer(ArrayBuffer buffer) => FactoryProviderImplementation.U16(buffer);
+ factory Uint16Array.fromBuffer(ArrayBuffer buffer, [int byteOffset, int length])
+ => FactoryProviderImplementation.U16(buffer, byteOffset, length);
factory Uint32Array(int length) => FactoryProviderImplementation.U32(length);
factory Uint32Array.fromList(List<num> list) => FactoryProviderImplementation.U32(list);
- factory Uint32Array.fromBuffer(ArrayBuffer buffer) => FactoryProviderImplementation.U32(buffer);
+ factory Uint32Array.fromBuffer(ArrayBuffer buffer, [int byteOffset, int length])
+ => FactoryProviderImplementation.U32(buffer, byteOffset, length);
}
class _WebKitPointFactoryProvider {
« client/tests/client/client.status ('K') | « client/tests/client/client.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698