Detect recursion during compilation of const constructors.

Detect recursion during compilation of const constructors.

We now give a message like this:

    Illegal recursion in const constructor 'A.'.
Committed: https://code.google.com/p/dart/source/detail?r=6128

[hausner, 2012-04-02 22:52:10]

I was hoping we could catch this in the parser without having to burn a field on
every function object. But in its general case, the circular dependency could be
more complicated (e.g. mutual recursion through more than one class.)

So, LGTM.

[srdjan, 2012-04-02 23:14:00]

Also make sure you clear the field in  Function::New() (object.cc)

On 2012/04/02 22:52:10, hausner wrote:
> I was hoping we could catch this in the parser without having to burn a field
on
> every function object. But in its general case, the circular dependency could
be
> more complicated (e.g. mutual recursion through more than one class.)
> 
> So, LGTM.

[turnidge, 2012-04-03 16:35:59]

Done.

On 2012/04/02 23:14:00, srdjan wrote:
> Also make sure you clear the field in  Function::New() (object.cc)
> 
> On 2012/04/02 22:52:10, hausner wrote:
> > I was hoping we could catch this in the parser without having to burn a
field
> on
> > every function object. But in its general case, the circular dependency
could
> be
> > more complicated (e.g. mutual recursion through more than one class.)
> > 
> > So, LGTM.

[turnidge, 2012-04-03 16:38:06]

Yes.  I was using a mutually recursive example to test the solution.

If we decide that we want to conserve space, we could collapse some of the bools
in RawFunction into bits.

On 2012/04/02 22:52:10, hausner wrote:
> I was hoping we could catch this in the parser without having to burn a field
on
> every function object. But in its general case, the circular dependency could
be
> more complicated (e.g. mutual recursion through more than one class.)
> 
> So, LGTM.