Detect recursion during compilation of const constructors.

runtime/vm/compiler.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/compiler.h"
 
 #include "vm/assembler.h"
 #include "vm/ast_printer.h"
 #include "vm/code_generator.h"
 #include "vm/code_index_table.h"
@@ skipping 93 matching lines @@
     error = isolate->object_store()->sticky_error();
     isolate->object_store()->clear_sticky_error();
   }
   isolate->set_long_jump_base(base);
   return error.raw();
 }
 
 
 static RawError* CompileFunctionHelper(const Function& function,
                                        bool optimized) {
+  if (function.is_compiling()) {
+    ASSERT(function.is_const() && function.IsConstructor());
+    const String& msg = String::Handle(String::NewFormatted(
+        "Illegal recursion in const constructor '%s'.",
+        String::Handle(function.name()).ToCString()));
+    return LanguageError::New(msg);
+  }
+  function.set_is_compiling(true);
   Isolate* isolate = Isolate::Current();
   Error& error = Error::Handle();
   LongJump* base = isolate->long_jump_base();
   LongJump jump;
   isolate->set_long_jump_base(&jump);
   if (setjmp(*jump.Set()) == 0) {
     TIMERSCOPE(time_compilation);
     ParsedFunction parsed_function(function);
     const char* function_fullname = function.ToFullyQualifiedCString();
     if (FLAG_trace_compiler) {
@@ skipping 172 matching lines @@
           ExceptionHandlers::Handle(code.exception_handlers());
       OS::Print("%s", handlers.ToCString());
       OS::Print("}\n");
     }
   } else {
     // We got an error during compilation.
     error = isolate->object_store()->sticky_error();
     isolate->object_store()->clear_sticky_error();
   }
   isolate->set_long_jump_base(base);
+  function.set_is_compiling(false);
   return error.raw();
 }
 
 
 RawError* Compiler::CompileFunction(const Function& function) {
   return CompileFunctionHelper(function, false);
 }
 
 
 RawError* Compiler::CompileOptimizedFunction(const Function& function) {
@@ skipping 80 matching lines @@
   } else {
     result = isolate->object_store()->sticky_error();
     isolate->object_store()->clear_sticky_error();
   }
   isolate->set_long_jump_base(base);
   return result.raw();
 }
 
 
 }  // namespace dart