Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 9960018: Various perf/selenium script cleanup (Closed)

Created:
8 years, 8 months ago by vsm
Modified:
8 years, 8 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Various perf/selenium script cleanup suggested in earlier CLs Committed: https://code.google.com/p/dart/source/detail?r=6219

Patch Set 1 #

Total comments: 7

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -74 lines) Patch
M tools/testing/perf_testing/run_perf_tests.py View 1 8 chunks +48 lines, -46 lines 0 comments Download
M tools/testing/run_selenium.py View 8 chunks +18 lines, -28 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
vsm
https://chromiumcodereview.appspot.com/9960018/diff/1/tools/testing/perf_testing/run_perf_tests.py File tools/testing/perf_testing/run_perf_tests.py (right): https://chromiumcodereview.appspot.com/9960018/diff/1/tools/testing/perf_testing/run_perf_tests.py#newcode857 tools/testing/perf_testing/run_perf_tests.py:857: # etc. above. Emily: I didn't change the names ...
8 years, 8 months ago (2012-04-04 18:09:02 UTC) #1
Emily Fortuna
lgtm with comments! Thanks! https://chromiumcodereview.appspot.com/9960018/diff/1/tools/testing/perf_testing/run_perf_tests.py File tools/testing/perf_testing/run_perf_tests.py (right): https://chromiumcodereview.appspot.com/9960018/diff/1/tools/testing/perf_testing/run_perf_tests.py#newcode857 tools/testing/perf_testing/run_perf_tests.py:857: # etc. above. On 2012/04/04 ...
8 years, 8 months ago (2012-04-04 18:30:58 UTC) #2
vsm
PTAL https://chromiumcodereview.appspot.com/9960018/diff/1/tools/testing/perf_testing/run_perf_tests.py File tools/testing/perf_testing/run_perf_tests.py (right): https://chromiumcodereview.appspot.com/9960018/diff/1/tools/testing/perf_testing/run_perf_tests.py#newcode857 tools/testing/perf_testing/run_perf_tests.py:857: # etc. above. On 2012/04/04 18:30:58, Emily Fortuna ...
8 years, 8 months ago (2012-04-04 20:05:09 UTC) #3
Emily Fortuna
lgtm!
8 years, 8 months ago (2012-04-04 23:10:50 UTC) #4
vsm
8 years, 8 months ago (2012-04-05 14:39:35 UTC) #5
Thanks, landed!

Can you update the folder names on the perf machines accordingly?

Powered by Google App Engine
This is Rietveld 408576698