Various perf/selenium script cleanup

tools/testing/perf_testing/run_perf_tests.py

 #!/usr/bin/python
 
 # Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 import datetime
 import getpass
 import math
 from matplotlib.font_manager import FontProperties
@@ skipping 480 matching lines @@
     for browser in get_browsers():
       for version in self.versions:
         self.trace_file = os.path.join('tools', 'testing', 'perf_testing',
             self.result_folder_name,
             'perf-%s-%s-%s' % (self.cur_time, browser, version))
         self.add_svn_revision_to_trace(self.trace_file)
         file_path = os.path.join(os.getcwd(), 'internal', 'browserBenchmarks',
             'benchmark_page_%s.html' % version)
         run_cmd(['python', os.path.join('tools', 'testing', 'run_selenium.py'),
             '--out', file_path, '--browser', browser,
-            '--timeout', '600', '--perf'], self.trace_file, append=True)
+            '--timeout', '600', '--mode', 'perf'], self.trace_file, append=True)
 
   def process_file(self, afile):
     """Comb through the html to find the performance results."""
     os.chdir(os.path.join(DART_INSTALL_LOCATION, 'tools', 'testing',
         'perf_testing'))
     parts = afile.split('-')
     browser = parts[2]
     version = parts[3]
     f = open(os.path.join(self.result_folder_name, afile))
     lines = f.readlines()
@@ skipping 75 matching lines @@
       for version_name in versions:
         version = version_name.replace('_','&')
         self.trace_file = os.path.join('tools', 'testing', 'perf_testing',
             self.result_folder_name,
             'dromaeo-%s-%s-%s' % (self.cur_time, browser, version_name))
         self.add_svn_revision_to_trace(self.trace_file)
         file_path = os.path.join(os.getcwd(), dromaeo_path,
             'index-js.html?%s' % version)
         run_cmd(['python', os.path.join('tools', 'testing', 'run_selenium.py'),
             '--out', file_path, '--browser', browser,
-            '--timeout', '200', '--dromaeo'], self.trace_file, append=True)
+            '--timeout', '200', '--mode', 'dromaeo'], self.trace_file, append=True)
 
   def process_file(self, afile):
     """Comb through the html to find the performance results."""
     parts = afile.split('-')
     browser = parts[2]
     version = parts[3]
 
     bench_dict = self.values_dict[browser][version]
 
     f = open(os.path.join(self.result_folder_name, afile))
@@ skipping 238 matching lines @@
 
   def plot_results(self, png_filename):
     self.style_and_save_perf_plot('Compiled minfrog Sizes',
         'Size (in bytes)', 10, 10, 'lower left', png_filename, [COMMAND_LINE],
         [FROG], ['swarm', 'total', 'minfrog'])
 
     self.style_and_save_perf_plot('Time to compile and bootstrap',
         'Seconds', 10, 10, 'lower left', '2' + png_filename, [COMMAND_LINE],
         [FROG], ['Bootstrapping', 'Compiling on Dart VM'])
 
+# TODO(vsm): Make these names consistent with BROWSER_PERF, CL_PERF,
+# etc. above.

[vsm, 2012/04/04 18:09:02]

Emily: I didn't change the names as it seems like this would screw up your
existing data.  The names below are the old flag names.

[Emily Fortuna, 2012/04/04 18:30:58]

Don't worry about the old flag names. Change as you see fit. I should be able to
make adjustments to directory names on my perf machines if needed.

[vsm, 2012/04/04 20:05:09]

Done.

+SUITES = {
+    'command-line': CommandLinePerformanceTest,
+    'size-time': CompileTimeAndSizeTest,
+    'browser-perf': BrowserStandalonePerformanceTest,
+    'dromaeo': DromaeoTest,
+    'dromaeo-size': DromaeoSizeTest,
+}
+
 def parse_args():
   parser = optparse.OptionParser()
   # TODO(vsm): Change to a list to scale.
-  parser.add_option('--command-line', '-c', dest='cl',
-      help='Run the command line tests',
-      action='store_true', default=False)
-  parser.add_option('--size-time', '-s', dest='size',
-      help='Run the code size and timing tests',
-      action='store_true', default=False)
-  parser.add_option('--browser-perf', '-b', dest='perf',
-      help='Run the browser performance tests',
-      action='store_true', default=False)
-  parser.add_option('--dromaeo', '-d', dest='dromaeo',
-      help='Run the Dromaeo performance tests',
-      action='store_true', default=False)
-  parser.add_option('--dromaeo-size', '-D', dest='dsize',
-      help='Run the Dromaeo size tests',
-      action='store_true', default=False)
+  parser.add_option('--suites', '-s', dest='suites',
+      help='Run the specified test suites',

[Emily Fortuna, 2012/04/04 18:30:58]

add "comma separated" and perhaps list the valid options that are SUITES?

[vsm, 2012/04/04 20:05:09]

Done.

+      action='store', default=None)
   parser.add_option('--forever', '-f', dest='continuous',
       help='Run this script forever, always checking for the next svn '
       'checkin', action='store_true', default=False)
   parser.add_option('--verbose', '-v', dest='verbose',
       help='Print extra debug output', action='store_true', default=False)
   parser.add_option('--nobuild', '-n', dest='no_build', action='store_true',
       help='Do not sync with the repository and do not rebuild.', default=False)
   parser.add_option('--graph-only', '-g', dest='graph_only', default=False,
       help='Do not run tests, only regenerate graphs', action='store_true')
   parser.add_option('--user', '-u', dest='username',
       help='Username for submitting new data to App Engine', default='')
 
   args, ignored = parser.parse_args()
   password = ''
   if args.username != '':
     password = getpass.getpass("App Engine Password: ")
   else:
     print 'Warning: performance data will not be uploaded to App Engine' + \
         ' if you do not provide a username.'
-  if not (args.cl or args.size or args.perf or args.dromaeo or args.dsize):
-    args.cl = args.size = args.perf = args.dromaeo = args.dsize = True
-  return (args.cl, args.size, args.perf, args.dromaeo, args.dsize,
-          args.continuous, args.verbose, args.no_build, args.graph_only,
-          args.username, password)
 
-def run_test_sequence(cl, size, perf, dromaeo, dsize, no_build, graph_only,
+  if not args.suites:
+    suites = SUITES.values()
+  else:
+    suites = []
+    suitelist = args.suites.split(',')
+    for name in suitelist:
+      if name in SUITES:
+        suites.append(SUITES[name])
+      else:
+        print 'Error: invalid suite %s' % name
+        sys.exit(1)
+  return (suites, args.continuous, args.verbose, args.no_build,
+          args.graph_only, args.username, password)
+
+def run_test_sequence(suites, no_build, graph_only,
                       username, password):
   # The buildbot already builds and syncs to a specific revision. Don't fight
   # with it or replicate work.
   if (not no_build or not graph_only) and sync_and_build() == 1:
     return # The build is broken.
-  if size:
-    CompileTimeAndSizeTest().run(graph_only)
-  if cl:
-    CommandLinePerformanceTest().run(graph_only)
-  if perf:
-    BrowserStandalonePerformanceTest().run(graph_only)
-  if dromaeo:
-    DromaeoTest().run(graph_only)
-  if dsize:
-    DromaeoSizeTest().run(graph_only)
+
+  for test in suites:
+    test().run(graph_only)
 
   if username != '':
     upload_to_app_engine(username, password)
 
 def main():
   global VERBOSE
-  (cl, size, perf, dromaeo, dsize, continuous, verbose, no_build, graph_only,
-      username, password) = parse_args()
+  (suites, continuous, verbose, no_build, graph_only,
+   username, password) = parse_args()

[Emily Fortuna, 2012/04/04 18:30:58]

can you move this back up to one line now?

[vsm, 2012/04/04 20:05:09]

It doesn't fit in 80.

On 2012/04/04 18:30:58, Emily Fortuna wrote:

   VERBOSE = verbose
   if continuous:
     while True:
       if has_new_code():
-        run_test_sequence(cl, size, perf, dromaeo, dsize, no_build, graph_only,
+        run_test_sequence(suites, no_build, graph_only,
                           username, password)
       else:
         time.sleep(SLEEP_TIME)
   else:
-    run_test_sequence(cl, size, perf, dromaeo, dsize, no_build, graph_only,
+    run_test_sequence(suites, no_build, graph_only,
                       username, password)
 
 if __name__ == '__main__':
   main()