Remove temporary directories created by standalone/FileErrorTest.

Remove temporary directories created by standalone/FileErrorTest.


BUG=dart:2396
TEST=standalone/FileErrorTest

Committed: https://code.google.com/p/dart/source/detail?r=6171

[floitsch, 2012-04-04 15:59:06]

LGTM, but consider refactoring to share code.

https://chromiumcodereview.appspot.com/9960012/diff/1/tests/standalone/src/io...
File tests/standalone/src/io/FileErrorTest.dart (right):

https://chromiumcodereview.appspot.com/9960012/diff/1/tests/standalone/src/io...
tests/standalone/src/io/FileErrorTest.dart:38: Directory temp = tempDir();
I would prefer:
File createFileInTemporaryDirectory(relativePath, [void onError(e)]) {
  Directory temp = tempDir();
  ReceivePort p = new ReceivePort();
  p.receive((x, y) {
    p.close();
    temp.deleteRecursivelySync();
  });
  var file = new File("${temp.path}/$relativePath");
  file.onError = (e) {
    if (onError !== null) onError(e);
    p.toSendPort().send(null);
  };
  return file;
}

https://chromiumcodereview.appspot.com/9960012/diff/1/tests/standalone/src/io...
tests/standalone/src/io/FileErrorTest.dart:369: p.receive((x,y) {
space after comma. Also for all the copies.

[Bill Hesse, 2012-04-04 16:11:06]

https://chromiumcodereview.appspot.com/9960012/diff/1/tests/standalone/src/io...
File tests/standalone/src/io/FileErrorTest.dart (right):

https://chromiumcodereview.appspot.com/9960012/diff/1/tests/standalone/src/io...
tests/standalone/src/io/FileErrorTest.dart:38: Directory temp = tempDir();
There are some cases below where the onError handler is more complicated, so
this refactoring would not work, without being extended.  I want to get this in
so buildbot doesn't keep breaking, so I won't refactor now.

https://chromiumcodereview.appspot.com/9960012/diff/1/tests/standalone/src/io...
tests/standalone/src/io/FileErrorTest.dart:369: p.receive((x,y) {
On 2012/04/04 15:59:06, floitsch wrote:
> space after comma. Also for all the copies.

Done.

But it sure seems natural to write two dummy arguments this way, without a
space.