Remove temporary directories created by standalone/FileErrorTest.

tests/standalone/src/io/FileErrorTest.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // Dart test program for testing error handling in file I/O.
 
 #import("dart:io");
 #import("dart:isolate");
 
 Directory tempDir() {
@@ skipping 17 matching lines @@
         e.toString().indexOf(
             "The system cannot find the file specified") != -1);
   }
   // File not not found has error code 2 on all supported platforms.
   Expect.equals(2, e.osError.errorCode);
 
   return true;
 }
 
 void testOpenNonExistent() {
-  var file = new File("${tempDir().path}/nonExistentFile");
+  Directory temp = tempDir();

[floitsch, 2012/04/04 15:59:06]

I would prefer:
File createFileInTemporaryDirectory(relativePath, [void onError(e)]) {
  Directory temp = tempDir();
  ReceivePort p = new ReceivePort();
  p.receive((x, y) {
    p.close();
    temp.deleteRecursivelySync();
  });
  var file = new File("${temp.path}/$relativePath");
  file.onError = (e) {
    if (onError !== null) onError(e);
    p.toSendPort().send(null);
  };
  return file;
}

[Bill Hesse, 2012/04/04 16:11:06]

There are some cases below where the onError handler is more complicated, so
this refactoring would not work, without being extended.  I want to get this in
so buildbot doesn't keep breaking, so I won't refactor now.

+  ReceivePort p = new ReceivePort();
+  p.receive((x,y) {
+    p.close();
+    temp.deleteRecursivelySync();
+  });
+  var file = new File("${temp.path}/nonExistentFile");
 
   // Non-existing file should throw exception.
   Expect.throws(() => file.openSync(),
                 (e) => checkOpenNonExistentFileException(e));
 
   file.open(FileMode.READ, (raf) => Expect.fail("Unreachable code"));
-  file.onError = (e) => checkOpenNonExistentFileException(e);
+  file.onError = (e) {
+    checkOpenNonExistentFileException(e);
+    p.toSendPort().send(null);
+  };
 }
 
 bool checkDeleteNonExistentFileException(e) {
   Expect.isTrue(e is FileIOException);
   Expect.isTrue(e.osError != null);
   Expect.isTrue(e.toString().indexOf("Cannot delete file") != -1);
   Platform platform = new Platform();
   if (platform.operatingSystem() == "linux") {
     Expect.isTrue(e.toString().indexOf("No such file or directory") != -1);
   } else if (platform.operatingSystem() == "macos") {
     Expect.isTrue(e.toString().indexOf("No such file or directory") != -1);
   } else if (platform.operatingSystem() == "windows") {
     Expect.isTrue(
         e.toString().indexOf(
             "The system cannot find the file specified") != -1);
   }
   // File not not found has error code 2 on all supported platforms.
   Expect.equals(2, e.osError.errorCode);
 
   return true;
 }
 
 void testDeleteNonExistent() {
-  var file = new File("${tempDir().path}/nonExistentFile");
+  Directory temp = tempDir();
+  ReceivePort p = new ReceivePort();
+  p.receive((x,y) {
+    p.close();
+    temp.deleteRecursivelySync();
+  });
+  var file = new File("${temp.path}/nonExistentFile");
 
   // Non-existing file should throw exception.
   Expect.throws(() => file.deleteSync(),
                 (e) => checkDeleteNonExistentFileException(e));
 
   file.delete(() => Expect.fail("Unreachable code"));
-  file.onError = (e) => checkDeleteNonExistentFileException(e);
+  file.onError = (e) {
+    checkDeleteNonExistentFileException(e);
+    p.toSendPort().send(null);
+  };
 }
 
 bool checkCreateInNonExistentDirectoryException(e) {
   Expect.isTrue(e is FileIOException);
   Expect.isTrue(e.osError != null);
   Expect.isTrue(e.toString().indexOf("Cannot create file") != -1);
   Platform platform = new Platform();
   if (platform.operatingSystem() == "linux") {
     Expect.isTrue(e.toString().indexOf("No such file or directory") != -1);
     Expect.equals(2, e.osError.errorCode);
   } else if (platform.operatingSystem() == "macos") {
     Expect.isTrue(e.toString().indexOf("No such file or directory") != -1);
     Expect.equals(2, e.osError.errorCode);
   } else if (platform.operatingSystem() == "windows") {
     Expect.isTrue(
         e.toString().indexOf(
             "The system cannot find the path specified") != -1);
     Expect.equals(3, e.osError.errorCode);
   }
 
   return true;
 }
 
 void testCreateInNonExistentDirectory() {
-  var file = new File("${tempDir().path}/nonExistentDirectory/newFile");
+  Directory temp = tempDir();
+  ReceivePort p = new ReceivePort();
+  p.receive((x,y) {
+    p.close();
+    temp.deleteRecursivelySync();
+  });
+  var file = new File("${temp.path}/nonExistentDirectory/newFile");
 
   // Create in non-existent directory should throw exception.
   Expect.throws(() => file.createSync(),
                 (e) => checkCreateInNonExistentDirectoryException(e));
 
   file.create(() => Expect.fail("Unreachable code"));
-  file.onError = (e) => checkCreateInNonExistentDirectoryException(e);
+  file.onError = (e) {
+    checkCreateInNonExistentDirectoryException(e);
+    p.toSendPort().send(null);
+  };
 }
 
 bool checkFullPathOnNonExistentDirectoryException(e) {
   Expect.isTrue(e is FileIOException);
   Expect.isTrue(e.osError != null);
   Expect.isTrue(e.toString().indexOf("Cannot retrieve full path") != -1);
   Platform platform = new Platform();
   if (platform.operatingSystem() == "linux") {
     Expect.isTrue(e.toString().indexOf("No such file or directory") != -1);
   } else if (platform.operatingSystem() == "macos") {
     Expect.isTrue(e.toString().indexOf("No such file or directory") != -1);
   } else if (platform.operatingSystem() == "windows") {
     Expect.isTrue(
         e.toString().indexOf(
             "The system cannot find the file specified") != -1);
   }
   // File not not found has error code 2 on all supported platforms.
   Expect.equals(2, e.osError.errorCode);
 
   return true;
 }
 
 void testFullPathOnNonExistentDirectory() {
-  var file = new File("${tempDir().path}/nonExistentDirectory");
+  Directory temp = tempDir();
+  ReceivePort p = new ReceivePort();
+  p.receive((x,y) {
+    p.close();
+    temp.deleteRecursivelySync();
+  });
+  var file = new File("${temp.path}/nonExistentDirectory");
 
   // Full path non-existent directory should throw exception.
   Expect.throws(() => file.fullPathSync(),
                 (e) => checkFullPathOnNonExistentDirectoryException(e));
 
   file.fullPath((path) => Expect.fail("Unreachable code $path"));
-  file.onError = (e) => checkFullPathOnNonExistentDirectoryException(e);
+  file.onError = (e) {
+    checkFullPathOnNonExistentDirectoryException(e);
+    p.toSendPort().send(null);
+  };
 }
 
 bool checkDirectoryInNonExistentDirectoryException(e) {
   Expect.isTrue(e is FileIOException);
   Expect.isTrue(e.osError != null);
   Expect.isTrue(
       e.toString().indexOf("Cannot retrieve directory for file") != -1);
   Platform platform = new Platform();
   if (platform.operatingSystem() == "linux") {
     Expect.isTrue(e.toString().indexOf("No such file or directory") != -1);
   } else if (platform.operatingSystem() == "macos") {
     Expect.isTrue(e.toString().indexOf("No such file or directory") != -1);
   } else if (platform.operatingSystem() == "windows") {
     Expect.isTrue(
         e.toString().indexOf(
             "The system cannot find the file specified") != -1);
   }
   // File not not found has error code 2 on all supported platforms.
   Expect.equals(2, e.osError.errorCode);
 
   return true;
 }
 
 void testDirectoryInNonExistentDirectory() {
-  var file = new File("${tempDir().path}/nonExistentDirectory/newFile");
+  Directory temp = tempDir();
+  ReceivePort p = new ReceivePort();
+  p.receive((x,y) {
+    p.close();
+    temp.deleteRecursivelySync();
+  });
+  var file = new File("${temp.path}/nonExistentDirectory/newFile");
 
   // Create in non-existent directory should throw exception.
   Expect.throws(() => file.directorySync(),
                 (e) => checkDirectoryInNonExistentDirectoryException(e));
 
   file.directory((directory) => Expect.fail("Unreachable code"));
-  file.onError = (e) => checkDirectoryInNonExistentDirectoryException(e);
+  file.onError = (e) {
+    checkDirectoryInNonExistentDirectoryException(e);
+    p.toSendPort().send(null);
+  };
 }
 
 void testReadAsBytesNonExistent() {
-  var file = new File("${tempDir().path}/nonExistentFile3");
+  Directory temp = tempDir();
+  ReceivePort p = new ReceivePort();
+  p.receive((x,y) {
+    p.close();
+    temp.deleteRecursivelySync();
+  });
+  var file = new File("${temp.path}/nonExistentFile3");
 
   // Non-existing file should throw exception.
   Expect.throws(() => file.readAsBytesSync(),
                 (e) => checkOpenNonExistentFileException(e));
 
   file.readAsBytes((data) => Expect.fail("Unreachable code"));
-  file.onError = (e) => checkOpenNonExistentFileException(e);
+  file.onError = (e) {
+    checkOpenNonExistentFileException(e);
+    p.toSendPort().send(null);
+  };
 }
 
 void testReadAsTextNonExistent() {
-  var file = new File("${tempDir().path}/nonExistentFile4");
+  Directory temp = tempDir();
+  ReceivePort p = new ReceivePort();
+  p.receive((x,y) {
+    p.close();
+    temp.deleteRecursivelySync();
+  });
+  var file = new File("${temp.path}/nonExistentFile4");
 
   // Non-existing file should throw exception.
   Expect.throws(() => file.readAsTextSync(),
                 (e) => checkOpenNonExistentFileException(e));
 
   file.readAsText(Encoding.ASCII, (data) => Expect.fail("Unreachable code"));
-  file.onError = (e) => checkOpenNonExistentFileException(e);
+  file.onError = (e) {
+    checkOpenNonExistentFileException(e);
+    p.toSendPort().send(null);
+  };
 }
 
-void testReadAsLinesNonExistent() {
-  var file = new File("${tempDir().path}/nonExistentFile5");
+testReadAsLinesNonExistent() {
+  Directory temp = tempDir();
+  ReceivePort p = new ReceivePort();
+  p.receive((x,y) {
+    p.close();
+    temp.deleteRecursivelySync();
+  });
+  var file = new File("${temp.path}/nonExistentFile5");
 
   // Non-existing file should throw exception.
   Expect.throws(() => file.readAsLinesSync(),
                 (e) => checkOpenNonExistentFileException(e));
 
   file.readAsLines(Encoding.ASCII, (data) => Expect.fail("Unreachable code"));
-  file.onError = (e) => checkOpenNonExistentFileException(e);
+  file.onError = (e) {
+    checkOpenNonExistentFileException(e);
+    p.toSendPort().send(null);
+  };
 }
 
 bool checkWriteReadOnlyFileException(e) {
   Expect.isTrue(e is FileIOException);
   Expect.isTrue(e.osError != null);
   Expect.isTrue(e.osError.errorCode != OSError.noErrorCode);
   return true;
 }
 
 testWriteByteToReadOnlyFile() {
@@ skipping 72 matching lines @@
 bool checkFileClosedException(e) {
   Expect.isTrue(e is FileIOException);
   Expect.isTrue(e.toString().indexOf("File closed") != -1);
   Expect.isTrue(e.osError == null);
   return true;
 }
 
 testOperateOnClosedFile() {
   Directory temp = tempDir();
   ReceivePort p = new ReceivePort();
   p.receive((x,y) {

[floitsch, 2012/04/04 15:59:06]

space after comma. Also for all the copies.

[Bill Hesse, 2012/04/04 16:11:06]

Done.

But it sure seems natural to write two dummy arguments this way, without a
space.

     p.close();
     temp.deleteRecursivelySync();
   });
 
-  var file = new File("${tempDir().path}/test_file");
+  var file = new File("${temp.path}/test_file");
   file.createSync();
   var openedFile = file.openSync(FileMode.READ);
   openedFile.closeSync();
 
   List data = [0, 1, 2, 3];
   Expect.throws(() => openedFile.readByteSync(),
                 (e) => checkFileClosedException(e));
   Expect.throws(() => openedFile.writeByteSync(0),
                 (e) => checkFileClosedException(e));
   Expect.throws(() => openedFile.writeListSync(data, 0, data.length),
@@ skipping 51 matching lines @@
   testFullPathOnNonExistentDirectory();
   testDirectoryInNonExistentDirectory();
   testReadAsBytesNonExistent();
   testReadAsTextNonExistent();
   testReadAsLinesNonExistent();
   testWriteByteToReadOnlyFile();
   testWriteListToReadOnlyFile();
   testTruncateReadOnlyFile();
   testOperateOnClosedFile();
 }