Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 9956175: Add test of the HTTP headers object (Closed)

Created:
8 years, 8 months ago by Søren Gjesse
Modified:
8 years, 8 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add test of the HTTP headers object Fixed a number of bugs revealed by actually testing. R=ajohnsen@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=6669

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -14 lines) Patch
M runtime/bin/http_impl.dart View 6 chunks +22 lines, -14 lines 2 comments Download
A tests/standalone/src/io/HttpHeadersTest.dart View 1 chunk +118 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
8 years, 8 months ago (2012-04-17 15:28:46 UTC) #1
Anders Johnsen
LGTM, nice! :) https://chromiumcodereview.appspot.com/9956175/diff/1/runtime/bin/http_impl.dart File runtime/bin/http_impl.dart (right): https://chromiumcodereview.appspot.com/9956175/diff/1/runtime/bin/http_impl.dart#newcode66 runtime/bin/http_impl.dart:66: Date get expires() { Did we ...
8 years, 8 months ago (2012-04-18 06:34:52 UTC) #2
Søren Gjesse
https://chromiumcodereview.appspot.com/9956175/diff/1/runtime/bin/http_impl.dart File runtime/bin/http_impl.dart (right): https://chromiumcodereview.appspot.com/9956175/diff/1/runtime/bin/http_impl.dart#newcode66 runtime/bin/http_impl.dart:66: Date get expires() { On 2012/04/18 06:34:53, ajohnsen wrote: ...
8 years, 8 months ago (2012-04-18 06:40:16 UTC) #3
Anders Johnsen
8 years, 8 months ago (2012-04-18 06:41:50 UTC) #4
Okay, good. I just wanted to make sure we didn't break any other tests :)

Powered by Google App Engine
This is Rietveld 408576698