Add test of the HTTP headers object

runtime/bin/http_impl.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class _HttpHeaders implements HttpHeaders {
   _HttpHeaders() : _headers = new Map<String, List<String>>();
 
   List<String> operator[](String name) {
     name = name.toLowerCase();
     return _headers[name];
   }
 
   String value(String name) {
     name = name.toLowerCase();
     List<String> values = _headers[name];
     if (values == null) return null;
     if (values.length > 1) {
       throw new HttpException("More than one value for header $name");
     }
     return values[0];
   }
 
   void add(String name, Object value) {
     if (value is List) {
       for (int i = 0; i < value.length; i++) {
-        _add(name, vlaie[i]);
+        _add(name, value[i]);
       }
     } else {
       _add(name, value);
     }
   }
 
   void set(String name, Object value) {
     removeAll(name);
     add(name, value);
   }
@@ skipping 19 matching lines @@
     _host = host;
     _updateHostHeader();
   }
 
   int get port() => _port;
   void set port(int port) {
     _port = port;
     _updateHostHeader();
   }
 
   Date get expires() {

[Anders Johnsen, 2012/04/18 06:34:53]

Did we remove expires, host and port from the other Http classes altogether,
including tests for that?

[Søren Gjesse, 2012/04/18 06:40:16]

expires, host and port was removed from the other classes, but there are still
tests which test expires, host and port when being communicated from client to
server, look for these tests in tests/standalone/src/io/HttpTest.dart.

-    if (_expires == null) {
-      List<String> values = _headers["expires"];
-      if (values != null) {
-        _expires = _HttpUtils.parseDate(values[0]);
+    List<String> values = _headers["expires"];
+    if (values != null) {
+      try {
+        return _HttpUtils.parseDate(values[0]);
+      } catch (Exception e) {
+        return null;
       }
     }
-    return _expires;
   }
 
   void set expires(Date expires) {
-    _expires = expires;
     // Format "Expires" header with date in Greenwich Mean Time (GMT).
     String formatted =
-        _HttpUtils.formatDate(_expires.changeTimeZone(new TimeZone.utc()));
+        _HttpUtils.formatDate(expires.changeTimeZone(new TimeZone.utc()));
     _set("expires", formatted);
   }
 
   void _add(String name, Object value) {
     // TODO(sgjesse): Add immutable state throw HttpException is immutable.
     if (name.toLowerCase() == "expires") {
       if (value is Date) {
         expires = value;
       } else if (value is String) {
-        expires = _HttpUtils.parseDate(value);
+        _set("expires", value);
       } else {
         throw new HttpException("Unexpected type for header named $name");
       }
     } else if (name.toLowerCase() == "host") {
       int pos = value.indexOf(":");
       if (pos == -1) {
         _host = value;
         _port = HttpClient.DEFAULT_HTTP_PORT;
       } else {
-        _host = value.substring(0, pos);
+        if (pos > 0) {
+          _host = value.substring(0, pos);
+        } else {
+          _host = null;
+        }
         if (pos + 1 == value.length) {
           _port = HttpClient.DEFAULT_HTTP_PORT;
         } else {
-          _port = Math.parseInt(value.substring(pos + 1));
+          try {
+            _port = Math.parseInt(value.substring(pos + 1));
+          } catch (BadNumberFormatException e) {
+            _port = null;
+          }
         }
+        _set("host", value);
       }
-      _updateHostHeader();
     } else {
       name = name.toLowerCase();
       List<String> values = _headers[name];
       if (values == null) {
         values = new List<String>();
         _headers[name] = values;
       }
       values.add(value.toString());
     }
   }
 
   void _set(String name, String value) {
     name = name.toLowerCase();
     List<String> values = new List<String>();
     _headers[name] = values;
     values.add(value);
   }
 
   _updateHostHeader() {
-    String portPart = _port == HttpClient.DEFAULT_HTTP_PORT ? "" : ":$_port";
+    bool defaultPort = _port == null || _port == HttpClient.DEFAULT_HTTP_PORT;
+    String portPart = defaultPort ? "" : ":$_port";
     _set("host", "$host$portPart");
   }
 
   _write(_HttpConnectionBase connection) {
     final COLONSP = const [_CharCode.COLON, _CharCode.SP];
     final COMMASP = const [_CharCode.COMMA, _CharCode.SP];
     final CRLF = const [_CharCode.CR, _CharCode.LF];
 
     // Format headers.
     _headers.forEach((String name, List<String> values) {
@@ skipping 25 matching lines @@
       }
       sb.add("\n");
     });
     return sb.toString();
   }
 
   Map<String, List<String>> _headers;
 
   String _host;
   int _port;
-  Date _expires;
 }
 
 
 class _HttpRequestResponseBase {
   _HttpRequestResponseBase(_HttpConnectionBase this._httpConnection)
       : _contentLength = -1,
         _headers = new _HttpHeaders();
 
   int get contentLength() => _contentLength;
   HttpHeaders get headers() => _headers;
@@ skipping 1146 matching lines @@
     sockets.addFirst(socketConn);
     socketConn._markReturned();
   }
 
   Function _onOpen;
   Map<String, Queue<_SocketConnection>> _openSockets;
   Set<_SocketConnection> _activeSockets;
   Timer _evictionTimer;
   bool _shutdown;  // Has this HTTP client been shutdown?
 }