Issue 9949001: Improve help output and Windows VM hack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9949001: Improve help output and Windows VM hack. (Closed)

Created:
8 years, 8 months ago by Emily Fortuna

Modified:
8 years, 8 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Improve help output and Windows VM hack. Committed: https://code.google.com/p/dart/source/detail?r=6018

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -15 lines)			Patch
	M	tools/testing/dart/test_options.dart	View	1	1 chunk	+3 lines, -10 lines	0 comments	Download
	M	tools/testing/dart/test_runner.dart	View	1	2 chunks	+10 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

8 years, 8 months ago (2012-03-30 01:01:24 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/9949001/diff/1/tools/testing/dart/test...
File tools/testing/dart/test_runner.dart (right):

https://chromiumcodereview.appspot.com/9949001/diff/1/tools/testing/dart/test...
tools/testing/dart/test_runner.dart:211: /* A flag to indicate we have already
printed a warning about ignoring the VM
nit: use the style from all other comments
/**
 * A flag ...
 * ...
 */

https://chromiumcodereview.appspot.com/9949001/diff/1/tools/testing/dart/test...
tools/testing/dart/test_runner.dart:284: return false;
should we use: return !testCase.isNegative;

Expand Messages | Collapse Messages