Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 9949001: Improve help output and Windows VM hack. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/test_options.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
===================================================================
--- tools/testing/dart/test_runner.dart (revision 6015)
+++ tools/testing/dart/test_runner.dart (working copy)
@@ -208,6 +208,11 @@
Duration time;
List<String> diagnostics;
+ /* A flag to indicate we have already printed a warning about ignoring the VM
+ * crash, to limit the amount of output produced per test.
+ */
+ bool alreadyPrintedWarning = false;
+
/**
* Set to true if we encounter a condition in the output that indicates we
* need to rerun this test.
@@ -271,12 +276,12 @@
if (new Platform().operatingSystem() == 'windows' && exitCode == 253) {
for (String line in testCase.output.stdout) {
if (line.startsWith('VM exited with signal 1073741819')) {
- print("WARNING: VM crashed on this test with signal 1073741819. " +
- "This is a fake pass!!");
- if (testCase.expectedOutcomes.iterator().hasNext()) {
- return testCase.expectedOutcomes.iterator().next() == FAIL ? false :
- true;
+ if (!alreadyPrintedWarning) {
+ print("WARNING: VM crashed on this test with signal 1073741819. " +
+ "This is a fake pass!!");
+ alreadyPrintedWarning = true;
}
+ return testCase.expectedOutcomes.iterator().next() == FAIL;
}
}
}
« no previous file with comments | « tools/testing/dart/test_options.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698