Issue 9921030: Fix capturing of for-loop variables

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9921030: Fix capturing of for-loop variables (Closed)

Created:
8 years, 8 months ago by hausner

Modified:
8 years, 8 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix capturing of for-loop variables It was broken when there were captured variables in inner blocks. LocalFunctionTest had a test case that was expecting the wrong result. Add a few more test cases to For2Test.dart Fixes issue 2338 (http://code.google.com/p/dart/issues/detail?id=2338) Committed: https://code.google.com/p/dart/source/detail?r=6006

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -6 lines)			Patch
M	runtime/vm/parser.cc	View	1 2 3	1 chunk	+8 lines, -3 lines	0 comments	Download
M	tests/language/language.status	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/src/For2Test.dart	View	1 2 3	1 chunk	+32 lines, -1 line	0 comments	Download
M	tests/language/src/FunctionTest.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

lgtm