Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: runtime/vm/parser.cc

Issue 9921030: Fix capturing of for-loop variables (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/language.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
===================================================================
--- runtime/vm/parser.cc (revision 6004)
+++ runtime/vm/parser.cc (working copy)
@@ -4717,12 +4717,17 @@
// Check whether any of the variables in the initializer part of
// the for statement are captured by a closure. If so, we insert a
- // node that creates a new Context at the end of the loop body (but
- // before the increment expression is evaluated).
+ // node that creates a new Context for the loop variable before
+ // the increment expression is evaluated.
for (int i = 0; i < init_scope->num_variables(); i++) {
if (init_scope->VariableAt(i)->is_captured() &&
(init_scope->VariableAt(i)->owner() == init_scope)) {
- body->Add(new CloneContextNode(for_pos));
+ SequenceNode* incr_sequence = new SequenceNode(incr_pos, incr_scope);
+ incr_sequence->Add(new CloneContextNode(for_pos));
+ if (increment != NULL) {
+ incr_sequence->Add(increment);
+ }
+ increment = incr_sequence;
break;
}
}
« no previous file with comments | « no previous file | tests/language/language.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698