Visit name of DartDeclaration, set Element for DartIdentifier

Visit name of DartDeclaration, set Element for DartIdentifier

After this we could remove some of the workarounds in Editor.


R=zundel@google.com,messick@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=6037

[messick, 2012-03-29 16:15:23]

LGTM but I did not review the resolver changes; that's Eric's realm. Might be
good to get Brian to take a look at the changes to DartElementLocatorTest, too.

[Brian Wilkerson, 2012-03-29 21:22:31]

LGTM. Does this negate the need for ChildVisitor? (If so we can remove uses
incrementally over time.)

[zundel, 2012-03-29 23:20:06]

lgtm, with a couple of questions

https://chromiumcodereview.appspot.com/9921015/diff/1/compiler/java/com/googl...
File
compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java
(right):

https://chromiumcodereview.appspot.com/9921015/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java:314:
if (x.getParent() instanceof DartDeclaration<?>
I don't understand why this would happen. I thought that
CompileTimeConstantAnalyzer analyzed only the right hand side of an assignment.

https://chromiumcodereview.appspot.com/9921015/diff/1/compiler/javatests/com/...
File
compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java
(right):

https://chromiumcodereview.appspot.com/9921015/diff/1/compiler/javatests/com/...
compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java:1188:
public void test_resolveName_inDartDeclarations() throws Exception {
nit. I'm not sure why you chose to put this test in NegativeResolverTest.  (It
looks like a positive test to me)

[scheglov, 2012-03-30 01:25:26]

https://chromiumcodereview.appspot.com/9921015/diff/1/compiler/java/com/googl...
File
compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java
(right):

https://chromiumcodereview.appspot.com/9921015/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java:314:
if (x.getParent() instanceof DartDeclaration<?>
On 2012/03/29 23:20:06, zundel wrote:
> I don't understand why this would happen. I thought that
> CompileTimeConstantAnalyzer analyzed only the right hand side of an
assignment.

In this code we visit DartField, now including its name.


          if (element instanceof FieldNodeElement) {
            FieldNodeElement fieldNodeElement = (FieldNodeElement) element;
            DartNode fieldNode = fieldNodeElement.getNode();
            fieldNode.accept(this);

https://chromiumcodereview.appspot.com/9921015/diff/1/compiler/javatests/com/...
File
compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java
(right):

https://chromiumcodereview.appspot.com/9921015/diff/1/compiler/javatests/com/...
compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java:1188:
public void test_resolveName_inDartDeclarations() throws Exception {
On 2012/03/29 23:20:06, zundel wrote:
> nit. I'm not sure why you chose to put this test in NegativeResolverTest.  (It
> looks like a positive test to me)

Moved to ResolverCompilerTest.

[scheglov, 2012-03-30 01:27:54]

@zundel PTAL

[zundel, 2012-03-30 02:56:39]

lgtm