Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java

Issue 9921015: Visit name of DartDeclaration, set Element for DartIdentifier (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Visit more name-like nodes, tweaks for review Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java
diff --git a/compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java b/compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java
index c2bb276bd820109ed6ddc9c71e302667e0202021..caf651f3857365100bf36395a9d32d7eb4a5fc6f 100644
--- a/compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java
+++ b/compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java
@@ -154,6 +154,7 @@ public class MemberBuilder {
if (element != null) {
checkModifiers(element, method);
recordElement(method, element);
+ recordElement(method.getName(), element);
ResolutionContext previous = context;
context = context.extend(element.getName());
EnclosingElement previousEnclosingElement = enclosingElement;
@@ -200,6 +201,7 @@ public class MemberBuilder {
return method.getName().accept(new ASTVisitor<Element>() {
@Override public Element visitPropertyAccess(DartPropertyAccess node) {
Element element = node.getQualifier().accept(this);
+ recordElement(node.getQualifier(), element);
if (ElementKind.of(element).equals(ElementKind.CLASS)) {
return Elements.constructorFromMethodNode(
method, node.getPropertyName(), (ClassElement) currentHolder, (ClassElement) element);
@@ -276,6 +278,7 @@ public class MemberBuilder {
assertTopLevel(fieldNode);
}
fieldElement.setType(type);
+ recordElement(fieldNode.getName(), fieldElement);
return recordElement(fieldNode, fieldElement);
}
@@ -382,6 +385,7 @@ public class MemberBuilder {
fieldElement.setType(type);
}
}
+ recordElement(fieldNode.getName(), fieldElement);
return recordElement(fieldNode, fieldElement);
}

Powered by Google App Engine
This is Rietveld 408576698