Issue 9863043: Inline checks for super class and interfaces (checked mdoe improvements).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9863043: Inline checks for super class and interfaces (checked mdoe improvements). (Closed)

Created:
8 years, 9 months ago by srdjan

Modified:
8 years, 9 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Inline checks for super class and interfaces (checked mdoe improvements). Committed: https://code.google.com/p/dart/source/detail?r=5898

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -1 line)			Patch
	M	runtime/vm/code_generator_ia32.cc	View	1	2 chunks	+30 lines, -1 line	0 comments	Download
	M	runtime/vm/object.h	View		2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM, except for a missing null check. Also, we usually keep the 64-bit version in ...

8 years, 9 months ago (2012-03-27 18:43:37 UTC) #2

srdjan

8 years, 9 months ago (2012-03-27 18:50:42 UTC) #3

The inlined type checks need a major cleanup/refactoring, which will be done in
the new compiler x64, therefore I'd rather not port the changes there yet.

https://chromiumcodereview.appspot.com/9863043/diff/4001/runtime/vm/code_gene...
File runtime/vm/code_generator_ia32.cc (right):

https://chromiumcodereview.appspot.com/9863043/diff/4001/runtime/vm/code_gene...
runtime/vm/code_generator_ia32.cc:1548: __ movl(ECX, FieldAddress(ECX,
Type::type_class_offset()));
On 2012/03/27 18:43:37, regis wrote:
> What if the super type is null?

Adding comment:
        // Note that super-type can't be NULL as every Dart instance has
        // as supertype class Object.

Expand Messages | Collapse Messages