Inline checks for super class and interfaces (checked mdoe improvements).

runtime/vm/code_generator_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/code_generator.h"
 
 #include "lib/error.h"
@@ skipping 1524 matching lines @@
       } else {
         // Failed assignable type check: call runtime to throw TypeError.
         __ jmp(&runtime_call, Assembler::kNearJump);
       }
       // Compare if the classes are equal.
       __ Bind(&compare_classes);
       // If dst_type is an interface, we can skip the class equality check,
       // because instances cannot be of an interface type.
       if (!dst_type_class.is_interface()) {
         __ movl(ECX, FieldAddress(EAX, Object::class_offset()));
-        TestClassAndJump(dst_type_class, &done);
+        TestClassAndJump(dst_type_class, &done);  // Uses ECX.
+        // Check superclass
+        __ movl(ECX, FieldAddress(ECX, Class::super_type_offset()));
+        __ movl(ECX, FieldAddress(ECX, Type::type_class_offset()));

[regis, 2012/03/27 18:43:37]

What if the super type is null?

[srdjan, 2012/03/27 18:50:42]

Adding comment:
        // Note that super-type can't be NULL as every Dart instance has
        // as supertype class Object.

+        TestClassAndJump(dst_type_class, &done);  // Uses ECX.
       } else {
         // However, for specific core library interfaces, we can check for
         // specific core library classes.
         Error& malformed_error = Error::Handle();
         if (dst_type.IsBoolInterface()) {
           __ movl(ECX, FieldAddress(EAX, Object::class_offset()));
           const Class& bool_class = Class::ZoneHandle(
               Isolate::Current()->object_store()->bool_class());
           TestClassAndJump(bool_class, &done);
         } else if (dst_type.IsSubtypeOf(
@@ skipping 22 matching lines @@
               Isolate::Current()->object_store()->two_byte_string_class());
           TestClassAndJump(two_byte_string_class, &done);
           const Class& four_byte_string_class = Class::ZoneHandle(
               Isolate::Current()->object_store()->four_byte_string_class());
           TestClassAndJump(four_byte_string_class, &done);
         } else if (dst_type.IsFunctionInterface()) {
           __ movl(ECX, FieldAddress(EAX, Object::class_offset()));
           __ movl(ECX, FieldAddress(ECX, Class::signature_function_offset()));
           __ cmpl(ECX, raw_null);
           __ j(NOT_EQUAL, &done, Assembler::kNearJump);
+        } else {
+          // Check interfaces.
+          Label fall_through;
+          // Get interfaces array from class.
+          __ movl(EBX, FieldAddress(EAX, Object::class_offset()));
+          __ movl(EBX, FieldAddress(EBX, Class::interfaces_offset()));
+          __ cmpl(EBX, raw_null);
+          __ j(EQUAL, &fall_through, Assembler::kNearJump);
+          // Iterate over interfaces array and check if any of interfaces match.
+          __ movl(EDI, FieldAddress(EBX, Array::length_offset()));
+          // EDI: array index
+          // EBX: array
+          Label loop;
+          __ Bind(&loop);
+          __ subl(EDI, Immediate(Smi::RawValue(1)));
+          __ cmpl(EDI, Immediate(0));
+          __ j(LESS, &runtime_call, Assembler::kNearJump);
+          // EDI is Smi therefore TIMES_2 instead of TIMES_4.
+          // Get type from array.
+          __ movl(ECX, FieldAddress(EBX, EDI, TIMES_2, Array::data_offset()));
+          __ movl(ECX, FieldAddress(ECX, Type::type_class_offset()));
+          TestClassAndJump(dst_type_class, &done);  // Uses ECX.
+          __ jmp(&loop, Assembler::kNearJump);
+          // Fall through to runtime code.
+          __ Bind(&fall_through);
         }
       }
     }
   }
   __ Bind(&runtime_call);
   __ PushObject(Object::ZoneHandle());  // Make room for the result.
   const Immediate location =
       Immediate(reinterpret_cast<int32_t>(Smi::New(token_index)));
   __ pushl(location);  // Push the source location.
   __ pushl(EAX);  // Push the source object.
@@ skipping 1102 matching lines @@
   const Error& error = Error::Handle(
       Parser::FormatError(script, token_index, "Error", format, args));
   va_end(args);
   Isolate::Current()->long_jump_base()->Jump(1, error);
   UNREACHABLE();
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32