Minor tweaks to the core library.

Minor tweaks to the core library.

Committed: https://code.google.com/p/dart/source/detail?r=5818

[ngeoffray, 2012-03-25 18:22:17]

https://chromiumcodereview.appspot.com/9852018/diff/1/dart/frog/leg/lib/strin...
File dart/frog/leg/lib/string_helper.dart (right):

https://chromiumcodereview.appspot.com/9852018/diff/1/dart/frog/leg/lib/strin...
dart/frog/leg/lib/string_helper.dart:36: var result = new List();
This should be new List<Match>()

https://chromiumcodereview.appspot.com/9852018/diff/1/dart/frog/leg/lib/strin...
dart/frog/leg/lib/string_helper.dart:39: return [receiver];
receiver being a string and the returned type of that method being a List of
Match, I'm not sure how this can be right.

[Lasse Reichstein Nielsen, 2012-03-25 18:22:40]

https://chromiumcodereview.appspot.com/9852018/diff/1/dart/frog/leg/lib/strin...
File dart/frog/leg/lib/string_helper.dart (right):

https://chromiumcodereview.appspot.com/9852018/diff/1/dart/frog/leg/lib/strin...
dart/frog/leg/lib/string_helper.dart:35: allMatchesInStringUnchecked(receiver,
str) {
Could you add a comment to this method. The argument names aren't telling, so I
have no idea which is being looked for in what.
I'm assuming this finds instances of [str] in [receiver], and [receiver] is also
a string. (Or call them haystack and needle instead :)

https://chromiumcodereview.appspot.com/9852018/diff/1/dart/frog/leg/lib/strin...
dart/frog/leg/lib/string_helper.dart:39: return [receiver];
Is [receiver] a Match object? Because it seems we are returning a list of Match
objects below.

[ahe, 2012-03-25 19:07:31]

Hi Lasse and Nicolas,

Thank you for taking a look and catching some embarrassing confusion on my part.

I have copied the implementation from the VM instead and followed Lasse's clever
idea for naming.

PTAL.

Cheers,
Peter

[ngeoffray, 2012-03-26 07:00:30]

LGTM

https://chromiumcodereview.appspot.com/9852018/diff/3002/dart/frog/leg/lib/st...
File dart/frog/leg/lib/string_helper.dart (right):

https://chromiumcodereview.appspot.com/9852018/diff/3002/dart/frog/leg/lib/st...
dart/frog/leg/lib/string_helper.dart:35: List<Match>
allMatchesInStringUnchecked(needle, haystack) {
Could you type the parameters also?

[ahe, 2012-03-26 08:10:12]

Thank you!

https://chromiumcodereview.appspot.com/9852018/diff/3002/dart/frog/leg/lib/st...
File dart/frog/leg/lib/string_helper.dart (right):

https://chromiumcodereview.appspot.com/9852018/diff/3002/dart/frog/leg/lib/st...
dart/frog/leg/lib/string_helper.dart:35: List<Match>
allMatchesInStringUnchecked(needle, haystack) {
On 2012/03/26 07:00:30, ngeoffray wrote:
> Could you type the parameters also?

Done.

[floitsch, 2012-03-26 19:57:43]

LGTM.

https://chromiumcodereview.appspot.com/9852018/diff/8001/dart/frog/leg/lib/js...
File dart/frog/leg/lib/js_helper.dart (right):

https://chromiumcodereview.appspot.com/9852018/diff/8001/dart/frog/leg/lib/js...
dart/frog/leg/lib/js_helper.dart:702: start = receiver.length - 1;
You could avoid special casing by simply setting start to receiver.length. JS's
lastIndexOf should handle that just fine.