Issue 9836128: Again, forgot to save before uploading/comitting (just added a comment)

Issue 9836128: Again, forgot to save before uploading/comitting (just added a comment) (Closed)

Created:
8 years, 9 months ago by srdjan

Modified:
8 years, 9 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Again, forgot to save before uploading/comitting (just added a comment) Committed: https://code.google.com/p/dart/source/detail?r=5899

Patch Set 2 : #

Total comments: 3

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	runtime/vm/code_generator_ia32.cc	View	1	1 chunk	+2 lines, -0 lines	3 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/9836128/diff/3001/runtime/vm/code_generator_ia32.cc File runtime/vm/code_generator_ia32.cc (right): https://chromiumcodereview.appspot.com/9836128/diff/3001/runtime/vm/code_generator_ia32.cc#newcode1549 runtime/vm/code_generator_ia32.cc:1549: // as supertype class Object. Does that include ...

8 years, 9 months ago (2012-03-27 20:18:02 UTC) #2

srdjan

https://chromiumcodereview.appspot.com/9836128/diff/3001/runtime/vm/code_generator_ia32.cc File runtime/vm/code_generator_ia32.cc (right): https://chromiumcodereview.appspot.com/9836128/diff/3001/runtime/vm/code_generator_ia32.cc#newcode1549 runtime/vm/code_generator_ia32.cc:1549: // as supertype class Object. On 2012/03/27 20:18:02, regis ...

8 years, 9 months ago (2012-03-27 20:43:40 UTC) #3

srdjan

8 years, 9 months ago (2012-03-27 20:47:09 UTC) #4

https://chromiumcodereview.appspot.com/9836128/diff/3001/runtime/vm/code_gene...
File runtime/vm/code_generator_ia32.cc (right):

https://chromiumcodereview.appspot.com/9836128/diff/3001/runtime/vm/code_gene...
runtime/vm/code_generator_ia32.cc:1549: // as supertype class Object.
On 2012/03/27 20:43:40, srdjan wrote:
> On 2012/03/27 20:18:02, regis wrote:
> > Does that include a Dart instance of type Object?
> 
> Good point, I thought that we cannot allocate instances of class object, but
it
> seems we can. Will add check. Thanks!

Object.super_type is null, i.e., null object which has null class, so it should
be working fine. No checks needed (discussed offline).

Expand Messages | Collapse Messages