Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Unified Diff: runtime/vm/code_generator_ia32.cc

Issue 9836128: Again, forgot to save before uploading/comitting (just added a comment) (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_generator_ia32.cc
===================================================================
--- runtime/vm/code_generator_ia32.cc (revision 5898)
+++ runtime/vm/code_generator_ia32.cc (working copy)
@@ -1545,6 +1545,8 @@
TestClassAndJump(dst_type_class, &done); // Uses ECX.
// Check superclass
__ movl(ECX, FieldAddress(ECX, Class::super_type_offset()));
+ // Note that supertypes can't be NULL as every Dart instance has
+ // as supertype class Object.
regis 2012/03/27 20:18:02 Does that include a Dart instance of type Object?
srdjan 2012/03/27 20:43:40 Good point, I thought that we cannot allocate inst
srdjan 2012/03/27 20:47:09 Object.super_type is null, i.e., null object which
__ movl(ECX, FieldAddress(ECX, Type::type_class_offset()));
TestClassAndJump(dst_type_class, &done); // Uses ECX.
} else {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698