Stop ignoring compilation errors on compile_all

Stop ignoring compilation errors on compile_all

When compiling all code, stop compiling after the first error.
Previously, we ignored compilation errors.

This was a feature wish so we can detect errors in libraries.
In fact, there are errors in the library, e.g. references
to non-existing top-level functions in utf16 code. And possibly
others. If this code gets checked in, any tests that depends on
--compile_all will break.

First problem:

'dart:utf': Error: line 607 pos 7: identifier 'is16BitCodeUnit' is not declared in this scope
  if (is16BitCodeUnit()) {
      ^

If I hack that, the next one is:

'dart:utf': Error: line 613 pos 9: identifier 'utf16CodeUnitsToCodepoints' is not declared in this scope
        utf16CodeUnitsToCodepoints(codeunits, 0, null, replacementCodepoint));
        ^

Didn't investigate any more than that...
Committed: https://code.google.com/p/dart/source/detail?r=5835

[Mads Ager (google), 2012-03-23 23:21:36]

LGTM

This looks great! Thanks for doing it!

Do we currently have any tests on the VM that rely on compile_all? If not, I
think we should commit this. I can then add my test and work through the issues
filing bugs for anything I have to fix.

[Mads Ager (google), 2012-03-24 00:09:19]

I have a codereview out to fix the utf library. After that fix all tests pass on
the VM.

http://codereview.chromium.org/9835072/

[Mads Ager (google), 2012-03-24 00:29:43]

Anton, I have all tests passing with this on the VM at this point. Matthias
tells me that there might be a test that uses --compile_all to compile all of
the DOM libraries with Dartium. Is that true? If that is the case, could I
convince you to build a version of Dartium with this and run the tests?

[Ivan Posva, 2012-03-26 15:54:39]

LGTM -ip